Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Issues in *Asset Pricing with Incomplete Markets* #226

Open
spspitze opened this issue Jun 7, 2020 · 3 comments
Open

Minor Issues in *Asset Pricing with Incomplete Markets* #226

spspitze opened this issue Jun 7, 2020 · 3 comments

Comments

@spspitze
Copy link

spspitze commented Jun 7, 2020

Hello again. Some minor typos in Asset Pricing with Incomplete Markets

  1. For the pessimists' beliefs, you copied the optimists' beliefs.

  2. For price_optimistic_beliefs() (and pessimistic) you specify tol=1e-16 in during inputs but the code compares to 1e-12. Also there seems to be no need to pre-assign p_old before the loop starts.

  3. I didn't quite get why the price of the asset had to be weakly greater than 1, as the code assumes. What's the intuition for this restriction?

Thanks as always.

@jstac
Copy link
Contributor

jstac commented Jun 8, 2020

Thanks @spspitze, much appreciated. @Harveyt47, would you mind to take a look?

@Harveyt47
Copy link
Member

Hi @jstac yep I'll have a look at it now.

@Harveyt47
Copy link
Member

@spspitze is right the pessimists transition matrix here should be [[2/3, 1/3], [2/3, 1/3]] I believe.

Also we do not use tol in both price_optimistic_beliefs() and price_pessimistic_beliefs(). I'll make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants