Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems the 32 simulated spatial datasets are not so "spatial" #16

Open
hurazh opened this issue Jan 4, 2023 · 1 comment
Open

It seems the 32 simulated spatial datasets are not so "spatial" #16

hurazh opened this issue Jan 4, 2023 · 1 comment

Comments

@hurazh
Copy link

hurazh commented Jan 4, 2023

Hi,
Thank you for the benchmarking work of putting most of the existing methods together and providing a quantitative comparison of performances.
When I took a closer look at the 32 simulated spatial datasets (both the paper and the data you provided), I found there seem no spatial structures in these simulated spatial datasets, as the description in 'Methods' seems to treat each spot independently and no spatial coordinates for the spots are provided in the data (obs_names are just 0-999 and no Locations file are provided for the simulated datasets). The way you ran RCTD confirmed my suspicion, as in

coords <- data.frame(colnames(spatial_obj))
colnames(coords) <- 'barcodes'
coords$xcoord <- seq_along(colnames(spatial_obj))
coords$ycoord <- seq_along(colnames(spatial_obj))
rownames(coords) <- coords$barcodes; coords$barcodes <- NULL # Move barcodes to rownames

where you explicitly let the coords be {(1,1), (2,2), (3,3) ...} by seq_along such that all the spots lie along a straight line instead of some 2D region like real tissue samples.
As I understand it, spatial structure is crucial for spatial transcriptomics data. It is not only an annotation of the location of each spot but also provides some meaningful information that many existing methods, like RCTD, build upon.
I'm curious if this is intentional. If so, what's its purpose, and how are these simulated datasets "spatial"?

@noob000007
Copy link

i have the same question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants