Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create de.lua #35

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Create de.lua #35

merged 1 commit into from
Oct 6, 2024

Conversation

RoYaL69
Copy link
Contributor

@RoYaL69 RoYaL69 commented Oct 5, 2024 •
edited
Loading

Description

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Manason
Manason requested changes Oct 5, 2024
View reviewed changes
Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a QB style locale, not an ox_lib style one.

@RoYaL69
Copy link
Contributor Author

RoYaL69 commented Oct 5, 2024

This looks like a QB style locale, not an ox_lib style one.

just copied from en.lua, translated it and added the bottom from other languages with the 'de' switch. Other Projects use json from ox but here it is oldschool lua. Also if you look into is.lua there are much more values then in en.lua. Can u tell me whats exactly wrong do you think?

@mafewtm mafewtm merged commit b14dc06 into Qbox-project:main Oct 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manason Manason Manason requested changes

@mafewtm mafewtm mafewtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoYaL69 @Manason @mafewtm