Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.7 support #2956

Merged
merged 9 commits into from
Oct 10, 2023
Merged

Remove Python 3.7 support #2956

merged 9 commits into from
Oct 10, 2023

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Aug 17, 2023

Fixes NA

Summary/Motivation:

Per our policy, we will drop support for Python 3.7 after the next release. This PR makes appropriate changes.

Changes proposed in this PR:

  • Drop Python 3.7 support
  • Deprecate / relocate pyomo.common.backports because it's no longer necessary
  • Remove unnecessary checks / workarounds to Python 3.7

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt mrmundt changed the title Remove Python 3.7 support [WIP] Remove Python 3.7 support Aug 17, 2023
Copy link
Member

@jsiirola jsiirola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two requested changes, and of course, the obligatory note to not merge this until after the August release.

pyomo/repn/util.py Outdated Show resolved Hide resolved
pyomo/common/backports.py Show resolved Hide resolved
@mrmundt mrmundt requested a review from jsiirola August 17, 2023 17:17
pyomo/common/backports.py Outdated Show resolved Hide resolved
@mrmundt mrmundt requested a review from jsiirola August 24, 2023 12:44
@mrmundt mrmundt changed the title [WIP] Remove Python 3.7 support Remove Python 3.7 support Aug 24, 2023
@mrmundt mrmundt requested a review from blnicho August 31, 2023 14:35
Copy link
Member

@blnicho blnicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment/question on the PyPy versions listed in the README. Also, we'll need to remove the 3.7 test from Jenkins after this gets merged.

README.md Outdated Show resolved Hide resolved
@mrmundt mrmundt merged commit eb7d5cb into Pyomo:main Oct 10, 2023
25 checks passed
@mrmundt mrmundt deleted the python37-support branch October 10, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants