Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TypeError when adding skus to entitlements() method #2628

Merged
merged 7 commits into from
Oct 29, 2024
Merged

fix: TypeError when adding skus to entitlements() method #2628

merged 7 commits into from
Oct 29, 2024

Conversation

UnBonWhisky
Copy link
Contributor

Summary

Fix #2627 about the entitlements() method that raises TypeError when passing skus argument

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@UnBonWhisky
Fix Pycord-Development#2627
22fbaee 
Signed-off-by: UnBonWhisky <[email protected]>
@UnBonWhisky UnBonWhisky requested a review from a team as a code owner October 27, 2024 18:55
@pullapprove4 pullapprove4 bot requested a review from BobDotCom October 27, 2024 18:55
@UnBonWhisky UnBonWhisky changed the title Fix TypeError when adding Fix TypeError when adding skus to entitlements() method Oct 27, 2024
@UnBonWhisky UnBonWhisky changed the title Fix TypeError when adding skus to entitlements() method fix: TypeError when adding skus to entitlements() method Oct 27, 2024
@plun1331
Copy link
Member

changelog please :3

@plun1331 plun1331 added this to the v2.7 milestone Oct 28, 2024
@plun1331 plun1331 added bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer changelog needed labels Oct 28, 2024
plun1331
plun1331 reviewed Oct 29, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@plun1331
Update CHANGELOG.md
7ce7bc3 
Signed-off-by: plun1331 <[email protected]>
@plun1331 plun1331 requested a review from JustaSqu1d October 29, 2024 17:19
@plun1331 plun1331 enabled auto-merge (squash) October 29, 2024 17:19
@plun1331 plun1331 merged commit 05cf45e into Pycord-Development:master Oct 29, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

Assignees
No one assigned
Labels
bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.

TypeError when adding a sku in the entitlements() method
3 participants
@UnBonWhisky @plun1331 @Lulalaby