-
-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sending polls with PartialWebhook #2624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think the state parameter is artificial comment is necessary, but I left it to match the other methods |
Lulalaby
previously approved these changes
Oct 25, 2024
Lulalaby
requested review from
JustaSqu1d
and removed request for
FrostByte266
October 25, 2024 13:36
tyrantlink
changed the title
fix: sending polls wilth PartialWebhook
fix: sending polls with PartialWebhook
Oct 25, 2024
JustaSqu1d
suggested changes
Oct 25, 2024
JustaSqu1d
added
priority: medium
Medium Priority
status: awaiting review
Awaiting review from a maintainer
API Reflection
Discords API wasn't correctly reflected in the lib
python
Pull requests that update Python code
labels
Oct 25, 2024
auto-merge was automatically disabled
October 25, 2024 20:26
Head branch was pushed to by a user without write access
Signed-off-by: tyrantlink <[email protected]>
JustaSqu1d
suggested changes
Nov 1, 2024
JustaSqu1d
approved these changes
Nov 8, 2024
Lulalaby
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API Reflection
Discords API wasn't correctly reflected in the lib
priority: medium
Medium Priority
python
Pull requests that update Python code
status: awaiting review
Awaiting review from a maintainer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When attempting to send a poll through a PartialWebook with wait set to True, an AttributeError is raised. Full example code below
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.