Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Add creator monetization analytics perms (1 << 41) #2622

Conversation

Paillat-dev
Copy link
Contributor

@Paillat-dev Paillat-dev commented Oct 24, 2024

Summary

See https://discord.com/developers/docs/topics/permissions#:~:text=VIEW_CREATOR_MONETIZATION_ANALYTICS
I don't have setup to test this so pls if you think it needs to be tested, wait for someone to test it.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion
Copy link
Member

if you want, you can just roll all the missing perms into a single PR

@Paillat-dev
Copy link
Contributor Author

@NeloBlivion Sure, didn't do it in the first place as I felt like there might be conflicts in the soundboard one / wanting to implement soudboard features entirely in one go.

@NeloBlivion
Copy link
Member

Soundboard's kinda been in limbo for a while so you can just implement perms first, if you wanna tackle the rest of soundboard separately then go for it

@Paillat-dev Paillat-dev deleted the missing-creator-monetization-perms branch October 24, 2024 13:53
@Paillat-dev
Copy link
Contributor Author

Implemented in #2620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants