Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent unclosed client session / unclosed connector #2618

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: prevent unclosed client session / unclosed connector #2618

merged 1 commit into from
Oct 23, 2024

Conversation

honzajavorek
Copy link
Contributor

Summary

Fixes #2399. Takes inspiration from Rapptz/discord.py#1967.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@honzajavorek honzajavorek requested a review from a team as a code owner October 23, 2024 16:40
@pullapprove4 pullapprove4 bot requested a review from Middledot October 23, 2024 16:40
honzajavorek added a commit to juniorguru/junior.guru that referenced this pull request Oct 23, 2024
@honzajavorek
incorporate fix from Pycord-Development/pycord#2618
722fea9
@Lulalaby Lulalaby merged commit 1c9c5bb into Pycord-Development:master Oct 23, 2024
25 checks passed
@honzajavorek honzajavorek deleted the honzajavorek/fix-unclosed-connector branch October 23, 2024 18:37
baribarton pushed a commit to baribarton/pycord-no-potential-reconnect that referenced this pull request Oct 24, 2024
@honzajavorek @baribarton
fix: prevent unclosed client session / unclosed connector (Pycord-Dev…
9183efd 
…elopment#2618)

Takes inspiration from Rapptz/discord.py#1967
Fixes Pycord-Development#2399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Middledot Middledot Awaiting requested review from Middledot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclosed client session, Unclosed connector
2 participants
@honzajavorek @Lulalaby