Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 Union type cannot be used in ctx. #2611

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix: 🐛 Union type cannot be used in ctx. #2611

merged 2 commits into from
Oct 29, 2024

Conversation

Paillat-dev
Copy link
Contributor

@Paillat-dev Paillat-dev commented Oct 17, 2024 •
edited
Loading

Summary

A command's ctx parameter could not be typed as a Union which was especially problematic when using bridge

Information

  • This PR fixes an issue.
    fixes: bridge.Context not a valid context typehint #2378
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev Paillat-dev requested a review from a team as a code owner October 17, 2024 11:45
@pullapprove4 pullapprove4 bot requested a review from Middledot October 17, 2024 11:45
@pullapprove4 pullapprove4 bot requested a review from VincentRPS October 17, 2024 11:45
@Paillat-dev Paillat-dev changed the title 🐛 Union type cannot be used in ctx. fix: 🐛 Union type cannot be used in ctx. Oct 17, 2024
@Paillat-dev Paillat-dev force-pushed the fix-ctx-union branch 3 times, most recently from 72e3a75 to 8b5fe08 Compare October 17, 2024 15:48
@JustaSqu1d JustaSqu1d added priority: medium Medium Priority python Pull requests that update Python code labels Oct 21, 2024
@Lulalaby Lulalaby merged commit 59ab5ec into Pycord-Development:master Oct 29, 2024
24 of 25 checks passed
@Paillat-dev Paillat-dev deleted the fix-ctx-union branch October 29, 2024 15:54
Lulalaby pushed a commit that referenced this pull request Oct 29, 2024
@Paillat-dev @Lulalaby
fix: 🐛 Union type cannot be used in ctx. (#2611)
7e7cbdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Middledot Middledot Awaiting requested review from Middledot

@VincentRPS VincentRPS Awaiting requested review from VincentRPS

Assignees
No one assigned
Labels
priority: medium Medium Priority python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bridge.Context not a valid context typehint
3 participants
@Paillat-dev @Lulalaby @JustaSqu1d