Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Single Member Enums Fail Converting To Option #2577

Merged
merged 8 commits into from
Sep 16, 2024
Merged

fix: Single Member Enums Fail Converting To Option #2577

merged 8 commits into from
Sep 16, 2024

Conversation

Icebluewolf
Copy link
Contributor

@Icebluewolf Icebluewolf commented Sep 16, 2024 •
edited
Loading

Summary

This fixes an issue where a Enum with one member that is not of a type accepted by discord an error would be thrown during option conversion.
It also solves #2558

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Icebluewolf Icebluewolf requested a review from a team as a code owner September 16, 2024 01:16
@pullapprove4 pullapprove4 bot requested a review from Middledot September 16, 2024 01:16
@plun1331 plun1331 linked an issue Sep 16, 2024 that may be closed by this pull request
Declaring an enum option with no docstring causes an error #2558
Closed
3 tasks
@Icebluewolf @Dorukyum
Update discord/commands/options.py
cdd3ca1 
Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: Ice Wolfy <[email protected]>
@Lulalaby Lulalaby enabled auto-merge (squash) September 16, 2024 16:01
@Lulalaby Lulalaby merged commit 96180fb into Pycord-Development:master Sep 16, 2024
25 checks passed
@Icebluewolf Icebluewolf deleted the EnumDocStringFix branch September 16, 2024 17:33
baribarton pushed a commit to baribarton/pycord-no-potential-reconnect that referenced this pull request Oct 24, 2024
@Icebluewolf @pre-commit-ci
@Dorukyum @baribarton
fix: Single Member Enums Fail Converting To Option (Pycord-Developmen…
f355424 
…t#2577)

* fix: Check If Enum Has Docstring Before Using It As Option Description

* fix: Single Item Enums Of Invalid Types Not Converting To String

* chore: Update Changelog

* style(pre-commit): auto fixes from pre-commit.com hooks

* chore: I Used The Wrong PR Number

* Update discord/commands/options.py

Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: Ice Wolfy <[email protected]>

---------

Signed-off-by: Ice Wolfy <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dorukyum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@Middledot Middledot Awaiting requested review from Middledot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declaring an enum option with no docstring causes an error
3 participants
@Icebluewolf @Lulalaby @Dorukyum