Skip to content

Commit

Permalink
chore(python)!: remove support for python 3.8 (#2521)
Browse files Browse the repository at this point in the history
* chore(python)!: remove support for python 3.8

Needed for new docs + python 3.8 is gonna be EOL by october

* fix: changelog warning

Signed-off-by: Lala Sabathil <[email protected]>

---------

Signed-off-by: Lala Sabathil <[email protected]>
  • Loading branch information
Lulalaby authored Aug 12, 2024
1 parent c58505e commit fe295bb
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .flake8
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[flake8]
min_python_version = 3.8
min_python_version = 3.9

# Incompatible with black see https://github.com/ambv/black/issues/315
ignore =
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Bug Report
description: Report broken or incorrect behaviour
labels: unconfirmed bug
labels: ["unconfirmed bug"]
body:
- type: markdown
attributes:
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Feature Request
description: Suggest a feature for this library
labels: feature request
labels: ["feature request"]
body:
- type: input
attributes:
Expand Down
11 changes: 4 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,13 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
# Python 3.8/3.9 are on macos-13 but not macos-latest (macos-14-arm64)
python-version: ["3.9", "3.10", "3.11", "3.12"]
# Python 3.9 are on macos-13 but not macos-latest (macos-14-arm64)
# https://github.com/actions/setup-python/issues/696#issuecomment-1637587760
exclude:
- { python-version: "3.8", os: "macos-latest" }
- { python-version: "3.9", os: "macos-latest" }
include:
- { python-version: "3.8", os: "macos-13" }
- { python-version: "3.9", os: "macos-13" }

env:
OS: ${{ matrix.os }}
PYTHON: ${{ matrix.python-version }}
Expand Down Expand Up @@ -58,10 +55,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.8"
python-version: "3.9"
cache: "pip"
cache-dependency-path: "requirements/docs.txt"
check-latest: true
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ formats: []
build:
os: ubuntu-22.04
tools:
python: "3.8"
python: "3.9"

sphinx:
configuration: docs/conf.py
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,15 @@ possible (see our [Version Guarantees] for more info).

These changes are available on the `master` branch, but have not yet been released.

⚠️ **This Version Removes Support For Python 3.8** ⚠️

### Changed

- Renamed `cover` property of `ScheduledEvent` and `cover` argument of
`ScheduledEvent.edit` to `image`.
([#2496](https://github.com/Pycord-Development/pycord/pull/2496))
- ⚠️ **This Version Removes Support For Python 3.8** ⚠️
([#2521](https://github.com/Pycord-Development/pycord/pull/2521))

## [2.6.0] - 2024-07-09

Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Key Features
Installing
----------

**Python 3.8 or higher is required**
**Python 3.9 or higher is required**

To install the library without full voice support, run the following command:

Expand Down
7 changes: 3 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,14 @@ authors = [
]
description = "A Python wrapper for the Discord API"
readme = "README.rst"
requires-python = ">=3.8"
requires-python = ">=3.9"
license = {text = "MIT"}
classifiers = [
"Development Status :: 5 - Production/Stable",
"License :: OSI Approved :: MIT License",
"Intended Audience :: Developers",
"Natural Language :: English",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down Expand Up @@ -66,7 +65,7 @@ voice = {file = "requirements/voice.txt"}
[tool.setuptools_scm]

[tool.black]
target-version = ['py38', 'py39', 'py310', 'py311', 'py312']
target-version = ['py39', 'py310', 'py311', 'py312']

[tool.isort]
profile = "black"
Expand All @@ -85,7 +84,7 @@ extension-pkg-whitelist = [
"pydantic",
"ujson"
]
py-version = 3.8
py-version = 3.9

[tool.pylint.messages_control]
enable = [
Expand Down

0 comments on commit fe295bb

Please sign in to comment.