Bump metadata version to 2.4 to fix license bug #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a project sets `license = { file = "LICENSE" }`, we're currently emitting a `License-File` entry, but Metadata-Version 2.3, which is invalid and now gets rejected by PyPI. This change bumps the metadata version.
Alternatively, we could only bump the version if license files are used and use the old `License` field for `license = { file = "LICENSE" }` again, but i'm not aware of any index currently rejecting metadata version 2.4.
messense
approved these changes
Nov 28, 2024
|
this was a breaking change, twine does not allow metadata version 2.4: https://github.com/oconnor663/blake3-py/actions/runs/12079634972/job/33685800258 xref pypa/twine#1146 |
This was referenced Nov 29, 2024
plusvic
referenced
this pull request
in VirusTotal/yara-x
Nov 29, 2024
This was the version that built the a wheel package with Metadata-Version 2.3, which seems to be the larger version accepted by `pypa/gh-action-pypi-publish`, newer versions of `maturin`seem to be producing packages with Metadata-Version 2.4.
by pinning maturin to 1.7.5, we were able to push to pypi (twine check within pypa/gh-action-pypi-publish passes with metadata 2.3, and apparently pypi still accepts it). on a side note, pypa/twine#1123 was merged and as soon as that's released and propagated to pypa/gh-action-pypi-publish, your users should be green again using maturin 1.7.6. |
|
I think no action is required here: we're almost there ref pypa/gh-action-pypi-publish#308 |
|
pypa/[email protected] has been released with metadata 2.4 support 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a project sets
license = { file = "LICENSE" }, we're currently emitting aLicense-Fileentry, but Metadata-Version 2.3, which is invalid and now gets rejected by PyPI, breaking publish for projects usinglicense = { file = "LICENSE" }. This change bumps the metadata version.Alternatively, we could only bump the version if license files are used and use the old
Licensefield forlicense = { file = "LICENSE" }again, but i'm not aware of any index currently rejecting metadata version 2.4.