Add Remove Brackets Command #160270
Merged
Add Remove Brackets Command #160270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
//cc @hediet |
implementation will be much cleaner
|
Related: #134371 It would be cool if ctrl+delete would delete the bracket before the cursor and it's matching counterpart. |
|
@hediet is this ready to merge, or there is anything else to be done? I also wonder shouldn't this command be renamed to Delete Brackets instead? |
hediet
reviewed
Mar 2, 2023
src/vs/editor/contrib/bracketMatching/browser/bracketMatching.ts
Outdated
Show resolved
Hide resolved
hediet
approved these changes
Mar 2, 2023
ulugbekna
approved these changes
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: deletes highlighted brackets pair in current editor.
fixes Pustelto/Bracketeer#49
fixes Pustelto/Bracketeer#10
fixes Pustelto/Bracketeer#55
Motivation
Bracketeer has hard limitation as extensions can't read language configurations in the web (in case of Bracketeer
allsome brackets are hardcoded e.g. vscode dynamic<and>bracket matching).As a benefit of using native bracket model, there is small, but noticeable performance improvement.
I compared it on the contents of this file: https://github.com/microsoft/TypeScript/blob/main/lib/tsserverlibrary.d.ts
Bracketeer: latency 40ms-1s ~150ms for first time in position, then ~40ms
New command: always 2-11ms