Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications Not Sent Bug #52

Open
lshanker opened this issue Apr 29, 2018 · 3 comments
Open

Notifications Not Sent Bug #52

lshanker opened this issue Apr 29, 2018 · 3 comments
Labels

Comments

@lshanker
Copy link
Collaborator

lshanker commented Apr 29, 2018

Someone told me notifications stopped sending after they'd been using the app for a while. Could be an issue with the boot receiver or alarms?

@lshanker lshanker added the bug label Apr 29, 2018
@yatharthrawat
Copy link
Contributor

I think this has to do with the fact that we never kill our service and after a point of time the OS does it.
I could be wrong.

@lshanker
Copy link
Collaborator Author

lshanker commented Apr 30, 2018

Yeah it's a good thought but I don't think that's it. If you look at the JobService docs it says the service will end if you return false in onStartJob:

Return true from this method if your job needs to continue running. If you do this, the job remains active until you call jobFinished(JobParameters, boolean) to tell the system that it has completed its work, or until the job's required constraints are no longer satisfied.

Returning false from this method means your job is already finished. The system's wakelock for the job will be released, and onStopJob(JobParameters) will not be invoked.

https://developer.android.com/reference/android/app/job/JobService

@lshanker
Copy link
Collaborator Author

I was able to try the app on my friend's phone, and I saw that he didn't get a notification even though faves were available. When I ran dev on his phone and tried it again, everything worked fine... maybe reinstalling the app reset something?

@lshanker lshanker changed the title Notifications Bug Notifications Not Sent Bug Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants