Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for audio routing to TV #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix for audio routing to TV #137

wants to merge 1 commit into from

Conversation

jabbas
Copy link

@jabbas jabbas commented Sep 24, 2015

Fix for #103

@malard
Copy link
Member

malard commented Sep 24, 2015

jabbas there are specific overloads for different brands, we need to determine which is the faulty hardware the Yamaha or the Samsung TV, do you have a different brand TV to test with? this should not be a 'core' feature done for all models

@jabbas
Copy link
Author

jabbas commented Sep 24, 2015

Unfortunately i have only Samsung :( But check the comments from #103. It looks like Samsung doesn't send 05:40:11:00... Anyway, I don't think (but i'm no expert) that sending this explicitly (again, after the TV sent it) will do harm (except mess in the code).

@opdenkamp
Copy link
Contributor

Looks like we need to make this work around optional or vendor specific. System audio mode should be enabled by the TV, and adding this would always enable the external speakers when an AVR is found, even when configured not to be used.

@jabbas
Copy link
Author

jabbas commented Sep 25, 2015

Maybe, instead of doing lots of (incompatible quirks) let's have them configured in Kodi's (and other libcec enabled software) configuration AKA "Custom CEC commands when 'action' occurs"?

It will be easier for people without programming skills to fix issues for their setup.

What do you think about that?

@opdenkamp
Copy link
Contributor

Well, these quirks being handled automatically is what makes libCEC work and other implementations who lack this kind of thing fail, so I don't want to be adding something like "Custom CEC commands when 'action' occurs" but handle it automatically. I've hooked up a Samsung (though an old one) to an Onkyo AVR. Will get it tested tonight once the kid and wife allow me to break their audio ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants