Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom concrete error types #49

Open
kamiyaa opened this issue Dec 11, 2023 · 1 comment
Open

Use custom concrete error types #49

kamiyaa opened this issue Dec 11, 2023 · 1 comment
Assignees

Comments

@kamiyaa
Copy link
Contributor

kamiyaa commented Dec 11, 2023

I haven't used anyhow much myself, but from what I read online, I think it makes more sense to have custom error types as a library.

I think it should also help with

  • more concise errors
  • easier mocking (at least for coral)
    • being able to create tests for all possible errors returned from secure-signer

https://www.reddit.com/r/rust/comments/gqe57x/what_are_you_using_for_error_handling/

@JasonVranek
Copy link

This is a pretty old post. I see a lot of rust Ethereum projects using https://github.com/eyre-rs/eyre which is a better fork of anyhow. We can switch to this in future but consider it low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants