Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom NFTS #521

Open
mattgle opened this issue Nov 1, 2022 · 5 comments
Open

Custom NFTS #521

mattgle opened this issue Nov 1, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@mattgle
Copy link
Contributor

mattgle commented Nov 1, 2022

Description

As part of custom assets in plug we are also adding support for custom NFTs. At the moment the only category for nft that we have is DIP721v2

Design: https://www.figma.com/file/no61f8MMPQlPUIaXSX3zCn/Plug---Wallet?node-id=8406%3A2489

@ignaciosantise ignaciosantise added the enhancement New feature or request label Nov 3, 2022
@ignaciosantise ignaciosantise removed their assignment Nov 3, 2022
@alinasytnik
Copy link

alinasytnik commented Nov 15, 2022

✳️Improvement

Description

Replace the spinner with an NFT collection card on the "No items in this custom collection" message (or design needed)

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Collectibles tab
  4. Click the Add custom NFT button
  5. Add the NFT Collection, which you don't have in your wallet
    Current: Notice that Added Collection Card has a spinner spinning permanently.

Expected behavior

Add the “You don’t own NFTs from this collection.” pop-up error message and delete the empty Collection card.

Screenshots

RPReplay_Final1668545435.MP4

Smartphone (please complete the following information):

  • Device: iPhone 14 Pro
  • OS: iOS 16.0.1
  • Version 0.4.0(3)

@alinasytnik
Copy link

✳️Improvement

Description

Send option on ICNS view should be blocked.

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Collectibles tab
  4. Click on the ICNS collection
  5. Click on card of chosen ICNS name
    Current: Notice that Send option still not blocked.

Expected behavior

Send button should be disabled.

Screenshots

Image

Smartphone (please complete the following information):

  • Device: iPhone 14 Pro
  • OS: iOS 16.0.1
  • Version 0.4.0(3)

@alinasytnik
Copy link

alinasytnik commented Nov 15, 2022

✳️Improvement

Description

ICNS name card should contain the ICNS logo and ICNS name.

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Collectibles tab
  4. Click on the ICNS collection
    Current: Notice that ICNS cards doesn't have the ICNS logo and ICNS name.

Expected behavior

ICNS cards should have the ICNS logo and ICNS name.

Screenshots

Image

Example

Image

Smartphone (please complete the following information):

  • Device: iPhone 14 Pro
  • OS: iOS 16.0.1
  • Version 0.4.0(3)

@alinasytnik
Copy link

⚠️Bug

Description

More option on ICNS view doesn't work.

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Collectibles tab
  4. Click on the ICNS collection
  5. Click on card of chosen ICNS name.
  6. Click on the More button
    Current: Notice that More button doesn't redirect user to the ICNS site.

Expected behavior

The More button should redirect user to the ICNS web site.

Screenshots

RPReplay_Final1668551057.MP4

Smartphone (please complete the following information):

  • Device: iPhone 14 Pro
  • OS: iOS 16.0.1
  • Version 0.4.0(3)

This was referenced Nov 18, 2022
@alinasytnik
Copy link

alinasytnik commented Nov 24, 2022

[iOS] QA Done ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants