Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Accounts mobile #494

Open
mattgle opened this issue Oct 11, 2022 · 7 comments
Open

Import Accounts mobile #494

mattgle opened this issue Oct 11, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@mattgle
Copy link
Contributor

mattgle commented Oct 11, 2022

Description

We want to give the option to the users of importing sub-accounts using pem files, this is a change that the new controller will bring and we need to support it in the mobile apps too

@mattgle mattgle self-assigned this Oct 11, 2022
@mattgle mattgle mentioned this issue Oct 11, 2022
@alinasytnik
Copy link

✳️Improvement

Description

Show the error message if the account has already been imported.

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Activity tab
  4. Click the Change button
  5. Click the Create/Import account button
  6. Click on the Private Key (or the PEM file) button
  7. Insert PK (or PEM)
    Current: Notice that the Create Account modal is shown, and the user can add the already imported/created account.

Expected behavior

The "This account is already imported" message should be shown.

Screenshots

RPReplay_Final1666615328.mov
RPReplay_Final1666616146.MP4

Smartphone (please complete the following information):

  • Device: iPhone 14 Pro
  • OS: iOS 16.0.1
  • Version 0.3.0(9)

@alinasytnik
Copy link

⚠️Bug

Description

ICP transaction fails

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Tokens tab
  4. Click on ICP and choose the Send option
  5. Try to send ICP
    Current: Notice that the transaction failed.

Expected behavior

ICP transactions should be processed successfully

Screenshots

RPReplay_Final1666614497.MP4

Smartphone (please complete the following information):

  • Device: iPhone 14 Pro
  • OS: iOS 16.0.1
  • Version 0.3.0(9)

@alinasytnik
Copy link

⚠️Bug

Description

Validation for Private Key input.

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Activity tab
  4. Click the Change button
  5. Click the Create/Import account button
  6. Click on the Private Key button
  7. Insert Principal or Account ID instead of Private Key
    Current: Notice that the new subaccount was created.

Expected behavior

The user shouldn't be able to create a new subaccount this way. I think that we can add validation for the Private Key input.

Screenshots

RPReplay_Final1666353312.3.MP4

Smartphone (please complete the following information):

  • Device: iPhone 14 Pro
  • OS: iOS 16.0.1
  • Version 0.3.0(9)

@kevin4476
Copy link

kevin4476 commented Oct 25, 2022

⚠️ BUG: App doesn't allow download PEMs files

Testing Information

  • OS: Android
  • Cellphone version: Samsung Galaxy Note 9
  • Version Plug mobile: 0.3.0 (24)

Precondition

  • Have the last version of Plug Mobile

Issue: The app doesn’t allow to download the PEM file

  • Steps to recreate
    • Launch app
    • Go to Profile tab
    • Press Setting button
    • Press Export DFX Identify
    • Type password
    • Check the box
    • Press Continue button
    • Choice any account
    • Press Download PEM file button
  • Current: The app close the drawer and doesn’t download the file
WhatsApp.Video.2022-10-25.at.6.30.15.PM.mp4
  • Expected: The app should to download the file and to give the option the user to send the file
document_5098090987389977335.mp4

Additional Note

The application also does not allow you to import PEMs files

@ignaciosantise ignaciosantise added the enhancement New feature or request label Nov 3, 2022
@ignaciosantise ignaciosantise self-assigned this Nov 14, 2022
@alinasytnik
Copy link

✳️Improvement

Description

Show the more detailed error message "This account is already imported" instead of "Error while importing..." when account already imported or created.

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Activity tab
  4. Click the Change button
  5. Click the Create/Import account button
  6. Click on the Private Key (or the PEM file) button
  7. Try to add the already existing account.
    Current: Notice that the error message does not show the essence of the error.

Expected behavior

The "This account is already imported" message should be shown.

Screenshots

Image

Smartphone (please complete the following information):

  • Device: iPhone 14 Pro
  • OS: iOS 16.0.1
  • Version 0.4.0(3)

@alinasytnik
Copy link

⚠️Bug

Description

An error occurred during subaccount creation.

Precondition

  1. Create a NEW account
  2. Add the subaccount with a Private Key
  3. Add the subaccount with PEM File

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Activity tab
  4. Click the Change button
  5. Click the Create/Import account button
  6. Click on the Create Account button
    Current: Notice that the new subaccount wasn't created, and an error occurred.

Expected behavior

The user should be able to create a new subaccount.

Screenshots

RPReplay_Final1668546023.MP4

Smartphone (please complete the following information):

  • Device: iPhone 14 Pro
  • OS: iOS 16.0.1
  • Version 0.4.0(3)

@kevin4476
Copy link

kevin4476 commented Nov 16, 2022

⚠️ App gets slow

Testing Information

  • OS: Android
  • Cellphone version: Samsung Galaxy Note 9
  • Version Plug mobile: v0.4.0(26)

Precondition

  • Import account using the PEM file

Issue: When I import an Account using the PEM file the app it gets slow and the NFTs not load

  • Steps to recreate
    • Launch app
    • Import a sub account using a PEM file
  • Current: The app gets slow and not load the NFTs screen
WhatsApp.Video.2022-11-15.at.10.16.39.PM.mp4
  • Expected: The app should load the NFTs screen and shouldn’t gets slow

Additional Information

  • The application takes a long time to load the activity tab, but it never loads the NFTs screen

This was referenced Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants