Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong bubble position #215

Closed
alotex opened this issue Feb 27, 2019 · 6 comments · Fixed by #228 · May be fixed by ProseMirror/prosemirror-view#47
Closed

Wrong bubble position #215

alotex opened this issue Feb 27, 2019 · 6 comments · Fixed by #228 · May be fixed by ProseMirror/prosemirror-view#47

Comments

@alotex
Copy link

alotex commented Feb 27, 2019

ezgif-1-a99eb749f278

browser: latest chrome
os: macOS

@holtwick
Copy link

Here another example from demo. In Safari double click on the word "about":

screen shot 2019-02-27 at 11 17 48

@alotex
Copy link
Author

alotex commented Feb 28, 2019

Another screen record here.
screencast 2019-02-28 06-46-04

I've got digging into the sources and found a place where prosemirror calculates coordinations
https://github.com/ProseMirror/prosemirror-view/blob/master/src/domcoords.js#L237

@Chrissi2812
Copy link
Contributor

I have supplied a PR to prosemirror-view as their example also suffers from wrong positioning.
So if they merge it should fix our menububble too.

wrong-position

@Chrissi2812
Copy link
Contributor

Chrissi2812 commented Mar 7, 2019

The PR won't get merged unless these two issues (ProseMirror/prosemirror#900 ProseMirror/prosemirror#899) are solved in Prosemirror.

So the only option would to implement the changed cordsAtPos function into the menuBubble itself.

@nutheory
Copy link

center on selection start?

@nutheory
Copy link

i can do this 10 ways from tuesday whats prefered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants