Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

ERC1155 Clone + DefaultOperatorFilterUpgradeable #81

Open
ecmendenhall opened this issue Jan 5, 2023 · 1 comment
Open

ERC1155 Clone + DefaultOperatorFilterUpgradeable #81

ecmendenhall opened this issue Jan 5, 2023 · 1 comment

Comments

@ecmendenhall
Copy link

ecmendenhall commented Jan 5, 2023

Hi OpenSea team! We're deploying a system that uses a factory contract to deploy ERC1155 clones. Our implementation contract inherits DefaultOperatorFilterUpgradeable and supports EIP-2981.

Our verification fork tests pass, creator fees are enforced in the OpenSea testnet UI, and the mainnet contracts look like they are correctly registered with the operator filter, but we are still seeing optional creator fees on mainnet OpenSea. Implementation contract bytecode is the same on Goerli and mainnet. Any idea what might be going on? We were surprised by this in production, since fork tests and testnet deployments both looked OK.

Here's an example deployment tx from mainnet for one of the clone contracts.

@ecmendenhall ecmendenhall changed the title ERC1155 Clone ERC1155 Clone + DefaultOperatorFilterUpgradeable Jan 5, 2023
@ecmendenhall
Copy link
Author

ecmendenhall commented Jan 18, 2023

Update: like the folks in #82, we now see the "Refresh Eligibility" button on collection pages and were able to log in and push it to register. (We did have to push the button twice—maybe that's a clue). When I posted this issue originally, we weren't seeing this button on the collection page frontend.

I'm still curious whether there's something we're missing here, like an event OpenSea is listening for that our contract is missing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant