Skip to content

Latest commit

 

History

History
47 lines (29 loc) · 4.6 KB

CONTRIBUTING.md

File metadata and controls

47 lines (29 loc) · 4.6 KB

This document serves as a reference for the Mirador community and others interested in the project. It aims to outline agreed-upon practices that are used in the development and maintenance of the Mirador software.

Contributing to Mirador

Contributions to Mirador are always welcome!

It is always helpful to begin any large change by submitting an issue or engaging with the Mirador community. Mirador 3.0 and beyond adheres to semantic versioning so that adopters and contributors can better understand what changes can be expected in released versions of the software.

All contributions should be submitted as a GitHub pull request to the master branch. Pull requests must be reviewed and accepted by another Mirador maintainer and pass all continuous integration checks. Contributions should have tests for the feature or bug fix, documentation, should maintain high code coverage, and should conform to the Mirador agreed-upon coding style. Contributions should not include a “built” version of Mirador—this will help to reduce merge conflicts.

Code of Conduct

Everyone interacting in this community is expected to follow the Mirador Code of Conduct.

Accessibility

Mirador 3 aims to comply with the Web Content Accessibility Guidelines (WCAG) 2.1 AA. These guidelines, authored by the W3C and legally adopted internationally, are comprehensive and provide the success criteria designers and developers need to build accessible web applications.

Mirador’s documentation wiki offers additional information, tools, and resources for testing your contributions against accessibility criteria before submitting pull requests.

Adding dependencies

Careful consideration should be given when adding software dependencies to Mirador. During the code review process, new dependencies may be evaluated on the following considerations:

  • added size of the dependency
  • whether or not that dependency is maintained and tested
  • how the dependency may interact with Mirador embedded in other environments

As a general rule, dependencies added should not be committed directly, but should instead use a package manager to require the dependency.

Dependencies should also be scoped (both for style and script) so that they do not interact with a containing application.

Coding style

Mirador has adopted the Airbnb JavaScript Style Guide as its agreed-upon coding style for all contributions. This helps us ensure a consistent codebase with higher readability.

Testing

Mirador should be well-tested at several different levels. A component or class should be tested individually (unit tests) and the interaction of that component or class with other parts should also be tested (integration tests).

Documentation

Added or modified code should be appropriately documented using JSDoc comments and established project conventions.

Plugin architecture

Mirador 3 shifted to a plugin architecture to better support the wide array of uses of Mirador. This allows for the design to accommodate plugins in a more focused way. It also allows the community to maintain the core components while giving developers the freedom to develop new and innovative plugins. Your contribution might fit nicely as a Mirador plugin. For more on plugins, please see Mirador 3 Plugins and Creating a Mirador 3 Plugin in the wiki.

Support

If you have questions, please check the wiki, add a discussion question, post on the #mirador channel of the IIIF Slack workspace, or join a Mirador community call (see #mirador for call details). Slack and community calls are also both great places to meet users and maintainers.

Plugin architecture

Mirador 3 shifted to a plugin architecture to better support the wide array of uses of Mirador. This allows for the design to accommodate plugins in more focused way. It also allows the community to maintain the core components while giving developers the freedom to develop new and innovative plugins. Your contribution might fit nicely as a Mirador plugin.