Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows build #3

Open
fwcd opened this issue Mar 1, 2023 · 0 comments
Open

Fix Windows build #3

fwcd opened this issue Mar 1, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@fwcd
Copy link
Member

fwcd commented Mar 1, 2023

On Windows, running node in the repo directory unfortunately does not use the node binary from the user's PATH, but executes ./node.js using Windows' legacy JScript engine. This is due to Windows considering .js an 'executable' extension and clearly not what we want.

We should probably also set up Windows CI to prevent bugs like these from happening in the future.
@fwcd fwcd added the bug Something isn't working label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fwcd