add full client API support for Apollo client in plugin-graphql (as ESM)

[thescientist13]

Type of Change

• New Feature Request
• Documentation / Website
• Improvement / Suggestion
• Bug
• Other (please clarify below)

Summary

EDIT: not sure if this still applies anymore since i think we're OK with putting this plugin into "read only" mode, and so not really designed for mutations, only reads. Will revisit closer to 1.0 release.

As part of introducing the GraphQL plugin in #487, for various reasons, it wasn't possible to support @apollo/client completely, and so only a minimal API surface is available right now, essentially consisting of just a query method taking two params; query and variables.

Details

The main issue was due to ESM handling as I don't think all of Apollo's dependencies, including transitive, are fully ESM compliant.

This is an excerpt from the linked issue

Apollo Client

There were a number of issues / hacks / workarounds I bumped into while trying to use @apollo/client in client.js so I have put that work into a branch for now, but will still try and kick the tires for a bit longer

• Due to one of @apollo/client's dependencies still being CommonJS (fast-json-stable-stringify), including our plugin-import-commonjs was required
• Although ESM, graphql/language/parser.mjs doesn't provide a default export, which I had to handle using intercept
• There is an odd quirk with ts-invariant dependency needing to be resolved within @apollo/client package's node_modules
• Had to stop using getQueryHash for the time being since Apollo isn't available on the client now

---

Ultimately landed on this bug, same thing happened in apollo-client. 😞

[thescientist13]

Looks like there may be an RC we can opt into that might resolve our issues. 🤞
apollographql/apollo-client#7610 (comment)

[thescientist13]

Tracking against a couple more ESM migrations

• Add module field to package.json zenparsing/zen-observable#69
• Add native Node.js ES Modules support zenparsing/zen-observable#74
• Proposal to use Rollup to build as ESM and CJS epoberezkin/fast-json-stable-stringify#10
• Add native Node.js ES Modules support epoberezkin/fast-json-stable-stringify#20

[thescientist13]

In light of needing #532 as part of #576 and the fact that as v3.4 Apollo should support all of ESM, might be worth working on this now.

[thescientist13]

Better diff, since I think the branch got deleted? Or else I may still have it locally.

I think this can be looked into, but maybe better to wait until after #815 is merged first and after #537 ? We will need to lift deps of deps into the import map, and right now that import map is being managed manually. 😮‍💨

[thescientist13]

Per #952 / #1157 , we have marked this plugin specifically as read only and so mutations are not really in scope