New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isNewerOrEqualTo throws TypeError when comparing 2 different version types #86

Open

Archengius opened this issue Jun 17, 2021 · 2 comments

Archengius commented Jun 17, 2021

E.g when you're trying to compare PE version with PC one
It should probably just return false instead

Member

rom1504 commented Jun 17, 2021

I think an exception is pretty good since that comparison doesn't make sense

Author

Archengius commented Jun 17, 2021 •

edited

Loading

Exception with error message is good indeed, TypeError is not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment