Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useRouteParam should return string | undefined instead of just string #287

Open
znicholasbrown opened this issue Jul 26, 2023 · 1 comment

Comments

@znicholasbrown
Copy link
Contributor

I think we're relying on the type coming from useRoute so I might need to transfer this issue but a call to useRouteParam returns a type of string when in fact it can be undefined.

@pleek91
Copy link
Collaborator

pleek91 commented Sep 12, 2023

I really want to do this and make the types more similar to useRouteQueryParam. And maybe account for the fact that vue-router changes the param's value before it unmounts the component.

BUTTTT changing the types produced 132 errors in nebula-ui... So I don't think I'm going to tackle this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants