precommit checks && repo hygiene #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiezieziula
requested review from
gabcoyne,
serinamarie,
zzstoatzz,
EmilRex,
prefectcboyd and
robfreedy
as code owners
zzstoatzz
requested changes
May 19, 2023
devops/infrastructure-as-code/azure/prefect-agent-on-aks/prefect.yaml
Outdated
Show resolved
Hide resolved
devops/infrastructure-as-code/azure/prefect-agent-on-aks/prefect.yaml
Outdated
Show resolved
Hide resolved
devops/infrastructure-as-code/azure/prefect-agent-on-aks/prefect.yaml
Outdated
Show resolved
Hide resolved
devops/infrastructure-as-code/azure/prefect-agent-on-aks/prefect.yaml
Outdated
Show resolved
Hide resolved
…ct.yaml Co-authored-by: nate nowack <[email protected]>
…ct.yaml Co-authored-by: nate nowack <[email protected]>
…ct.yaml Co-authored-by: nate nowack <[email protected]>
…ct.yaml Co-authored-by: nate nowack <[email protected]>
|
@jamiezieziula conflict in |
|
@zzstoatzz looks better now |
zzstoatzz
previously approved these changes
Jun 2, 2023
serinamarie
added
status:waiting for maintainer
and removed
status:waiting for user
labels
gabcoyne
requested changes
Jun 27, 2023
devops/github-actions/docker-build-push-gcp-artifact-registry.yaml
Outdated
Show resolved
Hide resolved
| name: PR Review Reminder | ||
|
|
||
| on: | ||
| "on": |
There was a problem hiding this comment.
on is considered a bool in yaml and so if it's not quoted - yaml linters yell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce additional precommit checks & general cleanup of the repo
Resolves #171