Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not combine cmd line args(options),hparams,and config #8

Open
PrashanthaTP opened this issue Jun 20, 2021 · 1 comment
Open

Why not combine cmd line args(options),hparams,and config #8

PrashanthaTP opened this issue Jun 20, 2021 · 1 comment
Labels
codequality promote best coding practices

Comments

@PrashanthaTP
Copy link
Owner

Since in many places options,hparams,config parameters are being passed why not put them inside a common container?

create_from_grid_dataset(config,preprocess_logger)

train_model(args_options,params,config,train_logger)

test_model(args_options,params,config,test_logger)

@PrashanthaTP PrashanthaTP added the codequality promote best coding practices label Jun 20, 2021
@PrashanthaTP
Copy link
Owner Author

PrashanthaTP commented Aug 22, 2021

Yeah, seems good to me. Also we can merge options and hparams into one,
options = store(options,hparams,config)
so we can call

def function(options,...):
    ... = options.config 
    ... = options.hparams #hparams containes all keys of both original options and hparams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality promote best coding practices
Projects
None yet
Development

No branches or pull requests

1 participant