Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Refactor main model to move the optional id logic #806

Open
Jerry-Jinfeng-Guo opened this issue Oct 25, 2024 · 0 comments · May be fixed by #843
Open

[FEATURE] Refactor main model to move the optional id logic #806

Jerry-Jinfeng-Guo opened this issue Oct 25, 2024 · 0 comments · May be fixed by #843
Labels
feature New feature or request

Comments

@Jerry-Jinfeng-Guo
Copy link
Contributor

Jerry-Jinfeng-Guo commented Oct 25, 2024

At the moment, the optional id logic to be added via #771 is mainly implemented in main_model_impl.hpp. In this refactor, relevant logic is proposed to be moved to update.hpp and others accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Q4 2024
Development

Successfully merging a pull request may close this issue.

1 participant