Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LT-2 & LT-5 - Landing Legs - Somehow weaker than stock (LT-1 fixed) #858

Open
drewcassidy opened this issue May 18, 2020 · 6 comments
Open
Assignees
Labels
bug bug pertains to non-art issues restock base content is base restock Stock Bug Caused by a bug in the stock game

Comments

@drewcassidy
Copy link
Member

drewcassidy commented May 18, 2020

Describe the bug
the landing legs break more easily with restock installed

List of mods installed:

  • Restock
@drewcassidy drewcassidy added bug bug pertains to non-art issues restock base content is base restock labels May 18, 2020
@drewcassidy drewcassidy self-assigned this May 18, 2020
@drewcassidy
Copy link
Member Author

After many hours of frustration, I've come to the conclusion that the stock wheel module is just wildly inconsistent. I was able to get the restock version of the legs to survive a long drop like their stock counterparts did consistently, but only some of the time. Whether the legs survived or exploded seemed to correspond with how long after scene-change I did the drop?

I've pushed a refactored version of the .mu file to the master branch which should hopefully more closely match stock, but I'm at a complete loss as to how to fully solve this issue

@drewcassidy drewcassidy added the Stock Bug Caused by a bug in the stock game label May 19, 2020
@drewcassidy drewcassidy changed the title LT-1 Landing Strut - Somehow weaker than stock Landing Legs - Somehow weaker than stock May 19, 2020
@drewcassidy
Copy link
Member Author

...I may have read the original report wrong but I definitely was able to reproduce with the LT-1

@JonnyOThan
Copy link

I got a report that this is still happening on the LT-2. The commit that addressed this only changed the LT-1: 58d30d0

@sug44
Copy link
Contributor

sug44 commented Feb 25, 2024

Just fixed the LT-2 legs(#1007) the same way LT-1 legs were fixed in 58d30d0. What mine and 58d30d0 fix did was change the model hierarchy so that collider collections are not inside of wrapper objects and set object names to the same ones used in the stock leg. If you only change the hierarchy legs become rigid and if you only change the names legs stay weak, so it only works if you do both, although im probably missing something. Note that LT-5(the smallest legs) have the same issue, but I couldn't fix it since the hierarchy differs a lot from the stock one, but its possible if you know how to do ksp modeling. So this issue needs to be re-opened

@Poodmund Poodmund reopened this May 28, 2024
@Poodmund Poodmund changed the title Landing Legs - Somehow weaker than stock LT-2 & LT-5 - Landing Legs - Somehow weaker than stock (LT-1 fixed) May 28, 2024
@Poodmund
Copy link
Collaborator

Is this the cause for the LT-2 and LT-5 as shown here: #1003 (comment) ?

@sug44
Copy link
Contributor

sug44 commented May 29, 2024

@Poodmund If the vibration issue only happens to lt-2 and lt-5 but not to lt-1 legs then its most likely related to this issue. But I can only guess since I have no idea what causes this bug. You could check if the vibration issue presists on lt-2 legs after the #1007 fix to know for sure

@Poodmund Poodmund moved this to In progress in Maintenance Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug pertains to non-art issues restock base content is base restock Stock Bug Caused by a bug in the stock game
Projects
Status: In progress
Development

No branches or pull requests

4 participants