Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Add unique <title> tag to each page #946

Open
oneezy opened this issue Nov 10, 2016 · 2 comments
Open

Add unique <title> tag to each page #946

oneezy opened this issue Nov 10, 2016 · 2 comments

Comments

@oneezy
Copy link

oneezy commented Nov 10, 2016

In the Polymer Shop app, a unique <title> tag was added for each page.

I think it would be beneficial to add the same functionality to the PSK.

@jsilvermist
Copy link
Contributor

Agreed, I did this in PSK 1, but using a slightly hacky method since without using a setTimeout call in the page.js page callback it would change the title before calling pushState.

@oneezy
Copy link
Author

oneezy commented Nov 10, 2016

Here's the commit that was added in the Shop app for this,
https://github.com/Polymer/shop/pull/32/files

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants