Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side validation of values in offchain API #59

Open
monitz87 opened this issue Oct 3, 2018 · 0 comments
Open

Server-side validation of values in offchain API #59

monitz87 opened this issue Oct 3, 2018 · 0 comments
Labels
Github For Asana integration use only technical debt Maintainability improvements

Comments

@monitz87
Copy link
Contributor

monitz87 commented Oct 3, 2018

Right now offchain merely validates that the values sent to its API by the client are of the correct type. It would be better to implement validation of the values as well. While the ddos middleware and signature verification already protect the app from the majority of potential attacks, theoretically (although this is very unlikely) somebody could still slowly pollute our database with gibberish. These validations would also grant further insurance against changes in the client that may break the API in obscure ways.

@monitz87 monitz87 added technical debt Maintainability improvements Github For Asana integration use only labels Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github For Asana integration use only technical debt Maintainability improvements
Projects
None yet
Development

No branches or pull requests

1 participant