Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📡 New Funding Runtime APIs #416

Merged
merged 1 commit into from
Oct 14, 2024
Merged

📡 New Funding Runtime APIs #416

merged 1 commit into from
Oct 14, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Oct 11, 2024 •
edited
Loading

What?

Add 2 new APIs on pallet-funding:

  • calculate_otm_fee
  • get_funding_asset_min_max_amounts

Testing?

Tests with the same name inside the pallet tests.

@JuaniRios JuaniRios mentioned this pull request Oct 11, 2024
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Oct 11, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios mentioned this pull request Oct 11, 2024
Merged
@JuaniRios JuaniRios changed the title new funding runtime apis 📡 New Funding Runtime APIs Oct 11, 2024
@JuaniRios JuaniRios force-pushed the 10-11-new_funding_runtime_apis branch from b7cafae to f62d1f6 Compare October 11, 2024 12:20
@lrazovic lrazovic mentioned this pull request Oct 11, 2024
Merged
@lrazovic lrazovic force-pushed the 10-10-add_xcm_runtime_apis branch from 28b81b8 to 23f2a0f Compare October 11, 2024 12:53
@lrazovic lrazovic force-pushed the 10-11-new_funding_runtime_apis branch from f62d1f6 to ac966a0 Compare October 11, 2024 12:53
@JuaniRios JuaniRios force-pushed the 10-10-add_xcm_runtime_apis branch from 23f2a0f to d1a6d95 Compare October 11, 2024 13:29
@JuaniRios JuaniRios force-pushed the 10-11-new_funding_runtime_apis branch 2 times, most recently from 4950ad4 to deb94e6 Compare October 11, 2024 14:23
@JuaniRios JuaniRios changed the base branch from 10-10-add_xcm_runtime_apis to 10-11-chore_upgrade_and_cleanup October 11, 2024 14:23
@JuaniRios JuaniRios self-assigned this Oct 11, 2024
@JuaniRios JuaniRios requested review from lrazovic and vstam1 October 11, 2024 14:29
@JuaniRios JuaniRios marked this pull request as ready for review October 11, 2024 14:46
@JuaniRios JuaniRios force-pushed the 10-11-new_funding_runtime_apis branch from deb94e6 to e9408f0 Compare October 11, 2024 14:50
@JuaniRios JuaniRios mentioned this pull request Oct 14, 2024
Merged
lrazovic
lrazovic requested changes Oct 14, 2024
View reviewed changes
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion on how we might avoid the repetition of a few lines of code. Otherwise: LGTM.

pallets/funding/src/runtime_api.rs Show resolved Hide resolved
@JuaniRios JuaniRios mentioned this pull request Oct 14, 2024
Merged
@JuaniRios JuaniRios requested a review from lrazovic October 14, 2024 13:20
@lrazovic lrazovic force-pushed the 10-11-chore_upgrade_and_cleanup branch from d3e69b6 to 9245097 Compare October 14, 2024 13:50
@lrazovic lrazovic force-pushed the 10-11-new_funding_runtime_apis branch from e9408f0 to 9f02548 Compare October 14, 2024 13:50
@lrazovic Graphite App
Copy link
Member

lrazovic commented Oct 14, 2024 •
edited by JuaniRios
Loading

Merge activity

  • Oct 14, 9:51 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 14, 9:52 AM EDT: Graphite couldn't merge this pull request because a downstack PR 📡 Add XCM Runtime APIs #414 failed to merge.
  • Oct 14, 10:05 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 14, 10:05 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 14, 10:06 AM EDT: A user merged this pull request with Graphite.

Base automatically changed from 10-11-chore_upgrade_and_cleanup to main October 14, 2024 13:56
@JuaniRios JuaniRios force-pushed the 10-11-new_funding_runtime_apis branch from 9f02548 to 5780289 Compare October 14, 2024 14:05
@JuaniRios JuaniRios merged commit 7a1ff92 into main Oct 14, 2024
1 check passed
@JuaniRios JuaniRios deleted the 10-11-new_funding_runtime_apis branch October 14, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 Awaiting requested review from vstam1

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic