-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♲ Swap our custom to parity's skip-feeless-payment pallet #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on Graphite |
JuaniRios
force-pushed
the
10-09-use_skip-feeless-payment_pallet
branch
from
October 10, 2024 09:18
cd6f83d
to
c9e78e6
Compare
JuaniRios
changed the title
Use skip-feeless-payment pallet
♲ Swap our custom skip-feeless-payment pallet
Oct 10, 2024
JuaniRios
changed the title
♲ Swap our custom skip-feeless-payment pallet
♲ Swap our custom to parity's skip-feeless-payment pallet
Oct 10, 2024
JuaniRios
force-pushed
the
10-09-use_skip-feeless-payment_pallet
branch
2 times, most recently
from
October 10, 2024 09:28
ba802a3
to
2e404e0
Compare
JuaniRios
force-pushed
the
10-04-fix_funding_asset_ed_tests
branch
from
October 10, 2024 09:37
ca5c1f7
to
4e31469
Compare
JuaniRios
force-pushed
the
10-09-use_skip-feeless-payment_pallet
branch
from
October 10, 2024 09:38
2e404e0
to
5a539c1
Compare
JuaniRios
force-pushed
the
10-04-fix_funding_asset_ed_tests
branch
from
October 10, 2024 09:39
4e31469
to
1d24782
Compare
JuaniRios
force-pushed
the
10-09-use_skip-feeless-payment_pallet
branch
from
October 10, 2024 09:39
5a539c1
to
a025fec
Compare
JuaniRios
force-pushed
the
10-04-fix_funding_asset_ed_tests
branch
from
October 10, 2024 09:43
1d24782
to
5abe0bb
Compare
JuaniRios
force-pushed
the
10-09-use_skip-feeless-payment_pallet
branch
from
October 10, 2024 09:43
a025fec
to
3042530
Compare
JuaniRios
force-pushed
the
10-04-fix_funding_asset_ed_tests
branch
from
October 10, 2024 09:53
5abe0bb
to
662529b
Compare
JuaniRios
force-pushed
the
10-09-use_skip-feeless-payment_pallet
branch
3 times, most recently
from
October 10, 2024 10:00
3fcd7d2
to
0fbc9a1
Compare
lrazovic
force-pushed
the
10-04-fix_funding_asset_ed_tests
branch
from
October 10, 2024 11:58
662529b
to
d6faab3
Compare
JuaniRios
force-pushed
the
10-04-fix_funding_asset_ed_tests
branch
from
October 10, 2024 12:00
d6faab3
to
662529b
Compare
Merged
lrazovic
force-pushed
the
10-04-fix_funding_asset_ed_tests
branch
from
October 10, 2024 12:20
662529b
to
d6faab3
Compare
lrazovic
force-pushed
the
10-09-use_skip-feeless-payment_pallet
branch
from
October 10, 2024 12:20
0fbc9a1
to
5ba9aa5
Compare
JuaniRios
force-pushed
the
10-04-fix_funding_asset_ed_tests
branch
from
October 10, 2024 12:23
d6faab3
to
662529b
Compare
JuaniRios
force-pushed
the
10-09-use_skip-feeless-payment_pallet
branch
from
October 10, 2024 12:23
5ba9aa5
to
0fbc9a1
Compare
lrazovic
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo the TODO that we can now remove
lrazovic
reviewed
Oct 10, 2024
JuaniRios
force-pushed
the
10-09-use_skip-feeless-payment_pallet
branch
from
October 10, 2024 13:44
0fbc9a1
to
cbbec19
Compare
JuaniRios
force-pushed
the
10-04-fix_funding_asset_ed_tests
branch
from
October 10, 2024 13:47
662529b
to
75a6225
Compare
JuaniRios
force-pushed
the
10-09-use_skip-feeless-payment_pallet
branch
from
October 10, 2024 13:47
cbbec19
to
142908c
Compare
lrazovic
approved these changes
Oct 10, 2024
JuaniRios
changed the base branch from
10-04-fix_funding_asset_ed_tests
to
graphite-base/411
October 10, 2024 14:27
JuaniRios
force-pushed
the
10-09-use_skip-feeless-payment_pallet
branch
from
October 10, 2024 14:31
142908c
to
b622192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We forked parity's skip-feeless-payment pallet because it was buggy and unmerged. It's now stable so we can use it
Why?
So it's maintained as part of the SDK and not by us
How?
The signed extension needs also to be included as a pallet on the runtime.
The actual extension looks almost identical to ours
Testing?
Test the existing tests in integration_tests::credeintals
Q: are we actually testing that you cannot dispense twice using our custom CheckNonce extension?