Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♲ Swap our custom to parity's skip-feeless-payment pallet #411

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Oct 9, 2024

What?

We forked parity's skip-feeless-payment pallet because it was buggy and unmerged. It's now stable so we can use it

Why?

So it's maintained as part of the SDK and not by us

How?

The signed extension needs also to be included as a pallet on the runtime.
The actual extension looks almost identical to ours

Testing?

Test the existing tests in integration_tests::credeintals

Q: are we actually testing that you cannot dispense twice using our custom CheckNonce extension?

@JuaniRios JuaniRios force-pushed the 10-09-use_skip-feeless-payment_pallet branch from cd6f83d to c9e78e6 Compare October 10, 2024 09:18
@JuaniRios JuaniRios changed the title Use skip-feeless-payment pallet ♲ Swap our custom skip-feeless-payment pallet Oct 10, 2024
@JuaniRios JuaniRios changed the title ♲ Swap our custom skip-feeless-payment pallet ♲ Swap our custom to parity's skip-feeless-payment pallet Oct 10, 2024
@JuaniRios JuaniRios self-assigned this Oct 10, 2024
@JuaniRios JuaniRios requested review from lrazovic and vstam1 October 10, 2024 09:24
@JuaniRios JuaniRios marked this pull request as ready for review October 10, 2024 09:24
@JuaniRios JuaniRios force-pushed the 10-09-use_skip-feeless-payment_pallet branch 2 times, most recently from ba802a3 to 2e404e0 Compare October 10, 2024 09:28
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from ca5c1f7 to 4e31469 Compare October 10, 2024 09:37
@JuaniRios JuaniRios force-pushed the 10-09-use_skip-feeless-payment_pallet branch from 2e404e0 to 5a539c1 Compare October 10, 2024 09:38
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from 4e31469 to 1d24782 Compare October 10, 2024 09:39
@JuaniRios JuaniRios force-pushed the 10-09-use_skip-feeless-payment_pallet branch from 5a539c1 to a025fec Compare October 10, 2024 09:39
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from 1d24782 to 5abe0bb Compare October 10, 2024 09:43
@JuaniRios JuaniRios force-pushed the 10-09-use_skip-feeless-payment_pallet branch from a025fec to 3042530 Compare October 10, 2024 09:43
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from 5abe0bb to 662529b Compare October 10, 2024 09:53
@JuaniRios JuaniRios force-pushed the 10-09-use_skip-feeless-payment_pallet branch 3 times, most recently from 3fcd7d2 to 0fbc9a1 Compare October 10, 2024 10:00
@lrazovic lrazovic force-pushed the 10-04-fix_funding_asset_ed_tests branch from 662529b to d6faab3 Compare October 10, 2024 11:58
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from d6faab3 to 662529b Compare October 10, 2024 12:00
@lrazovic lrazovic force-pushed the 10-04-fix_funding_asset_ed_tests branch from 662529b to d6faab3 Compare October 10, 2024 12:20
@lrazovic lrazovic force-pushed the 10-09-use_skip-feeless-payment_pallet branch from 0fbc9a1 to 5ba9aa5 Compare October 10, 2024 12:20
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from d6faab3 to 662529b Compare October 10, 2024 12:23
@JuaniRios JuaniRios force-pushed the 10-09-use_skip-feeless-payment_pallet branch from 5ba9aa5 to 0fbc9a1 Compare October 10, 2024 12:23
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the TODO that we can now remove

runtimes/polimec/src/lib.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 10-09-use_skip-feeless-payment_pallet branch from 0fbc9a1 to cbbec19 Compare October 10, 2024 13:44
@JuaniRios JuaniRios requested a review from lrazovic October 10, 2024 13:45
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from 662529b to 75a6225 Compare October 10, 2024 13:47
@JuaniRios JuaniRios force-pushed the 10-09-use_skip-feeless-payment_pallet branch from cbbec19 to 142908c Compare October 10, 2024 13:47
Copy link
Contributor Author

JuaniRios commented Oct 10, 2024

Merge activity

  • Oct 10, 10:08 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 10, 10:32 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 10, 10:33 AM EDT: A user merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 10-04-fix_funding_asset_ed_tests to graphite-base/411 October 10, 2024 14:27
@JuaniRios JuaniRios changed the base branch from graphite-base/411 to main October 10, 2024 14:29
@JuaniRios JuaniRios force-pushed the 10-09-use_skip-feeless-payment_pallet branch from 142908c to b622192 Compare October 10, 2024 14:31
@JuaniRios JuaniRios merged commit c13fd7d into main Oct 10, 2024
1 check passed
@JuaniRios JuaniRios deleted the 10-09-use_skip-feeless-payment_pallet branch October 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants