-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💸 USDT transaction payments #403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on Graphite |
This was referenced Sep 27, 2024
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
September 27, 2024 11:38
f49c7d8
to
290b404
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
2 times, most recently
from
September 27, 2024 11:45
1c5ab2b
to
64e8904
Compare
lrazovic
approved these changes
Sep 27, 2024
lrazovic
approved these changes
Sep 27, 2024
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
September 30, 2024 12:51
9050fc9
to
9f8292f
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
September 30, 2024 12:52
64e8904
to
b17ad86
Compare
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
September 30, 2024 12:58
9f8292f
to
228d298
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
September 30, 2024 12:58
b17ad86
to
881ae63
Compare
Merged
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
September 30, 2024 13:00
228d298
to
ac29096
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
September 30, 2024 13:00
881ae63
to
a0d191f
Compare
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
September 30, 2024 13:05
ac29096
to
94ee09b
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
September 30, 2024 13:05
a0d191f
to
d1269bb
Compare
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
September 30, 2024 13:12
94ee09b
to
5115a7b
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
September 30, 2024 13:12
d1269bb
to
0d68b35
Compare
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
September 30, 2024 13:14
5115a7b
to
990eb8b
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
2 times, most recently
from
October 1, 2024 09:20
dd2d227
to
a6346c6
Compare
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
October 4, 2024 12:17
cbdb1d7
to
33630ab
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
October 4, 2024 12:17
d660244
to
b1f0a8d
Compare
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
October 7, 2024 13:02
33630ab
to
9c24271
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
October 7, 2024 13:02
b1f0a8d
to
05af248
Compare
lrazovic
force-pushed
the
09-24-usdt_transaction_payment
branch
from
October 8, 2024 13:27
05af248
to
0711b4f
Compare
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
October 9, 2024 09:59
9c24271
to
8eb1453
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
October 9, 2024 09:59
0711b4f
to
cc0ed0d
Compare
This was referenced Oct 9, 2024
lrazovic
force-pushed
the
09-19-otm_funding_tests
branch
from
October 10, 2024 11:57
8eb1453
to
cd0edbf
Compare
lrazovic
force-pushed
the
09-24-usdt_transaction_payment
branch
from
October 10, 2024 11:58
cc0ed0d
to
55f4136
Compare
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
October 10, 2024 11:59
cd0edbf
to
8eb1453
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
October 10, 2024 11:59
55f4136
to
cc0ed0d
Compare
Merged
lrazovic
force-pushed
the
09-19-otm_funding_tests
branch
from
October 10, 2024 12:20
8eb1453
to
cd0edbf
Compare
lrazovic
force-pushed
the
09-24-usdt_transaction_payment
branch
from
October 10, 2024 12:20
cc0ed0d
to
55f4136
Compare
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
October 10, 2024 12:22
cd0edbf
to
8eb1453
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
October 10, 2024 12:22
55f4136
to
cc0ed0d
Compare
JuaniRios
force-pushed
the
09-19-otm_funding_tests
branch
from
October 10, 2024 13:46
8eb1453
to
c14f528
Compare
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
October 10, 2024 13:46
cc0ed0d
to
26e32e8
Compare
JuaniRios
changed the base branch from
09-19-otm_funding_tests
to
graphite-base/403
October 10, 2024 14:12
JuaniRios
force-pushed
the
09-24-usdt_transaction_payment
branch
from
October 10, 2024 14:15
26e32e8
to
9e3183f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allow extrinsic fee payment with AssetHub assets that have a price in the oracle
Why?
Needed for OTM flow
How?
Testing?
In the next PR
Anything Else?
There already were some existing generic structs that implemented this logic, but they assumed the tip and fee to go to the same place. Since we want the fee to go to the Blockchain Operation Treasury, and the tip to go to the block author, we had to reimplement most logic.
The original struct was
FungiblesAdapter<CON, HC>
.where CON was the converter and HC the crediting of the fee.
Our solution copies that, but also implements a third generic, such that the second pays the fee-tip, and the third the fee. For more info check
pallet_asset_tx_payment::payment::FungiblesAdapter