Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

episodes_have_been_added_to_downloads shows when adding to playlists #277

Open
vlzuykov opened this issue Jul 15, 2023 · 4 comments
Open

Comments

@vlzuykov
Copy link
Contributor

When I Add to playlists an already downloaded episode, the app shows episodes_have_been_added_to_downloads message instead of episodes_have_been_added_to_playlists. This happens when Download episode option is enabled for this playlist.

@gemiren
Copy link
Collaborator

gemiren commented Jul 16, 2023

With 'Download episode' option enabled in the playlist the app will start downloading the episode after it's been added to the playlist. That's why you see this added to downloads message.

@vlzuykov
Copy link
Contributor Author

But this message appears even when this episode is already downloaded. Do you think that it is not necessary to change it?

@gemiren
Copy link
Collaborator

gemiren commented Jul 16, 2023

That message shouldn't show up if the episode is already downloaded. Will fix that.

@vlzuykov
Copy link
Contributor Author

vlzuykov commented Jul 16, 2023

With 'Download episode' option enabled in the playlist the app will start downloading the episode after it's been added to the playlist. That's why you see this added to downloads message.

When a user manually adds an episode to a playlist, he wants to make sure this episode is added to that playlist. Also the message about adding it to download is also very helpful. Maybe it's worth it to display "$d episodes have been added to playlists and downloads" when the 'Download episode' option is enabled in the playlist and the episode is not downloaded yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants