Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest Julia version to represent current performance #972

Merged
merged 2 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PrimeJulia/solution_1/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM julia:1.6-alpine3.13
FROM julia:1-alpine

WORKDIR /opt/app

Expand Down
2 changes: 1 addition & 1 deletion PrimeJulia/solution_2/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM julia:1.6.1-alpine3.13
FROM julia:1-alpine

WORKDIR /opt/app

Expand Down
2 changes: 1 addition & 1 deletion PrimeJulia/solution_3/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM julia:1.6-buster
FROM julia:1

WORKDIR /opt/app

Expand Down
4 changes: 2 additions & 2 deletions PrimeJulia/solution_3/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ optimizations. This is a sort-of "low-level" style implementation in
Julia to get as much as speed as possible out of the language. It is
*not* designed to be idiomatic Julia code.

This solution requires at least **Julia 1.5** to run. Julia 1.6 is
This solution requires at least **Julia 1.5** to run. the latest stable 1.X Julia version is
recommended and is used in the Docker image.

## Description
Expand Down Expand Up @@ -40,7 +40,7 @@ and bits are unset when the number is *prime*. This simplifies the
set_bit operation slightly (`arr[i] |= mask vs. arr[i] &= ~mask`).

If you see any room for improvement in the code or have any
suggestions, don't hesitate to open an issue, pull request (PR),
suggestions, don't hesitate to open an issue, pull request (PR),
Discussion, or the like. Don't forget to tag me at `@louie-github` so I
can be notified if my personal input is either wanted or needed.
I'm open to fixing stylistic issues or discussing cosmetic changes to
Expand Down
2 changes: 1 addition & 1 deletion PrimeJulia/solution_4/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM julia:1.6-buster
FROM julia:1

WORKDIR /opt/app

Expand Down