Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendertype_entity_translucent | Shader | Purpur 1.21.1 | ItemsAdder 4.0.5 #4249

Closed
6 tasks done
DxrkCxt opened this issue Dec 14, 2024 · 13 comments
Closed
6 tasks done
Labels
type: duplicate This issue or pull request already exists

Comments

@DxrkCxt
Copy link

DxrkCxt commented Dec 14, 2024

Terms

  • I'm using the very latest version of ItemsAdder and its dependencies.
  • I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
  • I've looked for already existing issues on the Issue Tracker and haven't found any.
  • I already searched on the plugin wiki to know if a solution is already known.
  • I already searched on the forums to check if anyone already has a solution for this.
  • I tested this with just ItemsAdder and its dependencies and with a vanilla client of the same version as the Server.

Discord Username (optional)

No response

What happened?

I installed the latest versions of all plugins: ProtocolLib, ModelEngine, ItemsAdder, LoneLibs, after restarting the server. I wrote /meg reload, then /iazip, then filled a file with a unique name in cloud storage and uploaded to the server. I get Resourcepack failed.
Tested on Fabric 1.21.1/1.21.4, FO 6.2.1, Fabric 1.21.4 + ViaFabricPlus, Vanilla 1.21.4/1.21.1.
Error I encountered for the first time: https://mclo.gs/V61yrl9 (client log)
After disabling text-effects, emotes, extract-shader in the ItemsAdder config and after a complete reboot of the server and /iazip: https://mclo.gs/fVm0ae4.

Steps to reproduce the issue

I installed the latest versions of all plugins: ProtocolLib, ModelEngine, ItemsAdder, LoneLibs, after restarting the server. I wrote /meg reload, then /iazip, then filled a file with a unique name in cloud storage and uploaded to the server. I get Resourcepack failed.
Tested on Fabric 1.21.1/1.21.4, FO 6.2.1, Fabric 1.21.4 + ViaFabricPlus, Vanilla 1.21.4/1.21.1.
Error I encountered for the first time: https://mclo.gs/V61yrl9 (client log)
After disabling text-effects, emotes, extract-shader in the ItemsAdder config and after a complete reboot of the server and /iazip: https://mclo.gs/fVm0ae4.

Server version

Server version: Purpur 1.21.1 build 2329 official

ItemsAdder Version

ItemsAdder 4.0.5

ProtocolLib Version

ver protocoll
[14:34:14 INFO]: ProtocolLib version 5.3.0
[14:34:14 INFO]: Provides read/write access to the Minecraft protocol.
[14:34:14 INFO]: Authors: dmulloy2 and comphenix

LoneLibs Version

ver lone
[14:34:22 INFO]: LoneLibs version 1.0.62
[14:34:22 INFO]: Collection of libs used by my plugins
[14:34:22 INFO]: Authors: LoneDev and others

Full Server Log

https://mclo.gs/fVm0ae4

Error (optional)

https://mclo.gs/fVm0ae4

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

@DxrkCxt DxrkCxt added the type: bug Something isn't working label Dec 14, 2024
@Andre601
Copy link
Collaborator

Please share your latest.log through https://mclo.gs as it help us getting all the necessary info required to solving this issue. Sending just the error doesn't help us at all here.

@DxrkCxt
Copy link
Author

DxrkCxt commented Dec 14, 2024

Please share your latest.log through https://mclo.gs as it help us getting all the necessary info required to solving this issue. Sending just the error doesn't help us at all here.

/iazip https://mclo.gs/oDiG7oV

I can't provide a full log, because there is a lot of technical information from my plugins in the console.

@Andre601
Copy link
Collaborator

I'm certain whatever "technical information" there is, it's not sensitive at all. And if it is shouldn't you print it in the console in the first place.

@DxrkCxt
Copy link
Author

DxrkCxt commented Dec 14, 2024

I'm certain whatever "technical information" there is, it's not sensitive at all. And if it is shouldn't you print it in the console in the first place.

I understand that and realize I'm creating difficulties, but I can provide any log information individually.

@Andre601
Copy link
Collaborator

And I ask you provide the full log as-is.

The one you provided is already questionable as the generated zip path lacks the path dividers (/) wich is odd and something no default logging would do here. Neither in console not log file.

@DxrkCxt
Copy link
Author

DxrkCxt commented Dec 14, 2024

#4177

I've seen this, can't this patch do that? I just noticed someone trying to get at the /core/core path which seems very odd.

@DxrkCxt
Copy link
Author

DxrkCxt commented Dec 14, 2024

And I ask you provide the full log as-is.

The one you provided is already questionable as the generated zip path lacks the path dividers (/) wich is odd and something no default logging would do here. Neither in console not log file.

My servers are running in docker via PufferPanel, this is a problem with the ItemsAdder code, specifically just the visual which is only output to the log, but previously everything worked I've been using ItemsAdder for a few years now.

@KrazyxWolf
Copy link

KrazyxWolf commented Dec 14, 2024

I had the same problem with the same cause, the cause is that rendertype_entity_translucent.json is added in the shaders folder causing the texturepack not to be applied correctly because the file was not found in a directory that repeats “core” twice

the solution I applied was to disable shader generation in the ModelEngine config, copy the shaders folder that generates model engine to the minecraft folder, delete the rendertype_entity_translucent.json file and delete the “minecraft:” part of the rendertype_entity_translucent.vsh and rendertype_entity_translucent.fsh file imports, I don't know if it is correct to do it but it worked in my case

@breitwan
Copy link

I've got the same problem today.

@DxrkCxt
Copy link
Author

DxrkCxt commented Dec 14, 2024

A solution that worked for me:

  1. Go into the ModelEngine folder and into config.yml and set the following value: Create-Shader: false
  2. Delete the folder in the ModelEngine folder 'resource pack' and '.data' folders.
  3. Write the command /meg reload and /iazip

Edit: I ran into another problem if I log in with 1.21.2+, I see horse armor instead of the boss. If I log in with 1.21.1, everything is fine.

@AnaNazzDev
Copy link

Solution:
Disable the config setting added here: #4177

@DxrkCxt
Copy link
Author

DxrkCxt commented Dec 15, 2024

Solution: Disable the config setting added here: #4177

[15:36:25 WARN]: [ItemsAdder] [Pack] pre-1.21.3 shader JSON found. Adding 1.21.3+ compatibility. File: resource pack/assets/minecraft/shaders/core/rendertype_entity_translucent.json
In the logs I threw above, you can see that this function is already working.
But for some reason, it's not working.

@LoneDev6
Copy link
Collaborator

LoneDev6 commented Dec 17, 2024

Possible duplicate of #4159
Read more here: #4159 (comment)

@LoneDev6 LoneDev6 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2024
@LoneDev6 LoneDev6 added type: duplicate This issue or pull request already exists and removed type: bug Something isn't working labels Dec 17, 2024
@LoneDev6 LoneDev6 removed the status in ItemsAdder Dec 17, 2024
@PluginBugs PluginBugs locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: duplicate This issue or pull request already exists
Projects
Status: No status
Development

No branches or pull requests

6 participants