Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable plugin built-in text shaders in config #4226

Closed
4 tasks done
Fanfaryy opened this issue Dec 9, 2024 · 2 comments
Closed
4 tasks done

Option to disable plugin built-in text shaders in config #4226

Fanfaryy opened this issue Dec 9, 2024 · 2 comments
Labels
type: bug Something isn't working
Milestone

Comments

@Fanfaryy
Copy link

Fanfaryy commented Dec 9, 2024

Terms

  • I'm using the very latest version of ItemsAdder and its dependencies.
  • I already searched on this Github page to check if the same suggestion was already reported.
  • I already searched on the plugin wiki to know if the feature is already implemented.
  • I already searched on the Discord server to know if anyone already has a solution for this or if the feature was already suggested.

Discord tag (optional)

fanfaryy

Describe the solution you'd like

I would like it to be possible in the config to disable overwriting text shaders from packages with shaders from the plugin.

Is your feature request related to a problem?

Yes, I can't add my own text effects because the plugin keeps overwriting them with its own ones.

Describe alternatives you've considered

Restore the ability to not overwrite by simply disabling the "text-effects" option in config (which doesn't work after the update where the blinking effect was added)

Additional context

No response

@Fanfaryy Fanfaryy added the type: feature request New feature request. label Dec 9, 2024
@CarraGrive
Copy link

was about to report the same issue, would be great to have this fixed for the next released

@LoneDev6
Copy link
Collaborator

It's a bug, will be fixed in the next update.
You will be able to disable that setting like before and regenerate your pack to apply the change.

@LoneDev6 LoneDev6 added this to the 4.0.6 milestone Dec 17, 2024
@LoneDev6 LoneDev6 moved this from New to Done in ItemsAdder Dec 17, 2024
@LoneDev6 LoneDev6 added type: bug Something isn't working and removed type: feature request New feature request. labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants