Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoScale in scale_engine.py #90

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

nicoddemus
Copy link
Contributor

The original code in qwt_scale_engine.cpp was setting the stepSize to zero.

Not sure the reason why this was changed, perhaps by accident?

Opening this for your consideration. 👍

The [original code in `qwt_scale_engine.cpp`](https://sourceforge.net/p/qwt/code/HEAD/tree/trunk/qwt/src/qwt_scale_engine.cpp#l826) was setting the `stepSize` to zero.

Not sure why this was changed, perhaps by accident?
@PierreRaybaut
Copy link
Collaborator

The original code in qwt_scale_engine.cpp was setting the stepSize to zero.

Not sure the reason why this was changed, perhaps by accident?

Opening this for your consideration. 👍

Actually the original code when PythonQwt was initiated was consistent with this implementation.

But, why not upgrade? 👍

@PierreRaybaut
Copy link
Collaborator

By the way, have you tested this with a real world example?

@nicoddemus
Copy link
Contributor Author

By the way, have you tested this with a real world example?

I'm in the process of migrating our internal plots library from PyQwt to PythonQwt, and this patch was used successfully by an ex-colleague of mine, so I can say with 99% confidence that it works -- but I did not managed to get our internal library working yet to validate this myself.

@PierreRaybaut PierreRaybaut merged commit 9022b5a into PlotPyStack:master Dec 10, 2024
6 of 9 checks passed
@PierreRaybaut
Copy link
Collaborator

By the way, have you tested this with a real world example?

I'm in the process of migrating our internal plots library from PyQwt to PythonQwt, and this patch was used successfully by an ex-colleague of mine, so I can say with 99% confidence that it works -- but I did not managed to get our internal library working yet to validate this myself.

Let me know when you're finished and I'll release a new version of PythonQwt right away.

@nicoddemus nicoddemus deleted the patch-2 branch December 10, 2024 16:45
@nicoddemus
Copy link
Contributor Author

Let me know when you're finished and I'll release a new version of PythonQwt right away.

Thanks, appreciate the prompt support!

Actually I would appreciate a new release with those two patches if you have the time to spare, as I'm marking some tests with @pytest.mark.skip because of this bug, and I won't be able to merge until those are resolved.

Of course, technically I could use a development version, but this is not so simple to do because we use conda internally, and it is not as easy to use a development version as if we were using pip.

@PierreRaybaut
Copy link
Collaborator

PierreRaybaut commented Dec 10, 2024

OK, that is done.

@nicoddemus
Copy link
Contributor Author

Thanks, really appreciate it! 🙇‍♂️

@PierreRaybaut
Copy link
Collaborator

You're welcome 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants