-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autoScale in scale_engine.py #90
Conversation
The [original code in `qwt_scale_engine.cpp`](https://sourceforge.net/p/qwt/code/HEAD/tree/trunk/qwt/src/qwt_scale_engine.cpp#l826) was setting the `stepSize` to zero. Not sure why this was changed, perhaps by accident?
Actually the original code when PythonQwt was initiated was consistent with this implementation. But, why not upgrade? 👍 |
By the way, have you tested this with a real world example? |
I'm in the process of migrating our internal plots library from PyQwt to PythonQwt, and this patch was used successfully by an ex-colleague of mine, so I can say with 99% confidence that it works -- but I did not managed to get our internal library working yet to validate this myself. |
Let me know when you're finished and I'll release a new version of PythonQwt right away. |
Thanks, appreciate the prompt support! Actually I would appreciate a new release with those two patches if you have the time to spare, as I'm marking some tests with Of course, technically I could use a development version, but this is not so simple to do because we use |
OK, that is done. |
Thanks, really appreciate it! 🙇♂️ |
You're welcome 🙂 |
The original code in
qwt_scale_engine.cpp
was setting thestepSize
to zero.Not sure the reason why this was changed, perhaps by accident?
Opening this for your consideration. 👍