Fix historic unexpected double activation of interactive tools

CHANGELOG.md

@@ -17,6 +17,14 @@ In this release, test coverage is 79%.
   * When showing the X/Y cross section plots (using the plot context menu), an empty
     label was displayed at the center of each of those plots
   * The label now shows "Enable a marker" as previously
+* Fix historic unexpected behavior of interactive tools:
+  * When triggering an interactive tool (e.g. by clicking on the corresponding toolbar
+    button), the tool `activate` method was called twice, which was not expected, but
+    was not causing any issue given the current implementation
+  * However, when defining custom interactive tools, this behavior could lead to
+    unexpected results (i.e. really executing activation actions twice)
+  * This is now fixed: the `activate` method is called only once when triggering an
+    interactive tool
 
 💥 New features / Enhancements:
 

plotpy/tools/base.py

@@ -236,14 +236,16 @@ def register_plot(self, baseplot: BasePlot) -> None:
             filter.set_cursor(curs, start_state)
 
     def interactive_triggered(self, action: QW.QAction) -> None:
-        """Slot called when the tool action is triggered
+        """Slot called when the interactive tool action group is triggered.
+        The purpose is to deactivate all other tools in the group.
+
+        Note that the tool itself has already been activated because the action
+        triggered the `activate` method.
 
         Args:
             action: tool action
         """
-        if action is self.action:
-            self.activate()
-        else:
+        if action is not self.action:
             self.deactivate()
 
     def activate(self) -> None: