Fix itertools bug #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiamPattinson
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Cheers for catching this, and sorry for taking so long to respond. I'm not sure what I was thinking using chain.from_iterable there, and it's clear that our tests aren't covering the code adequately enough. I'll raise some issues on the project and try to improve things over the next week or so.
This was referenced Nov 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two bugs in your identify_cocos function, one is the phi -> psi spelling error the other is that sigma_to_cocos returns an int which is not iterable