Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make internal use of keys and names consistent #1121

Open
dpanici opened this issue Jul 10, 2024 · 2 comments
Open

Make internal use of keys and names consistent #1121

dpanici opened this issue Jul 10, 2024 · 2 comments
Assignees
@zpotthoff
Labels
documentation Add documentation or better warnings etc. easy Short and simple to code or review P1 Lowest Priority, will get to eventually

Comments

@dpanici
Copy link
Collaborator

dpanici commented Jul 10, 2024 •
edited
Loading

For a future PR: The variable we call keys here and in the other util functions below is the same as what we call names in the compute functions above and in other files. We should probably rename for consistency across the code.

Originally posted by @ddudt in #1027 (comment)
@dpanici dpanici added documentation Add documentation or better warnings etc. low priority Nice to have, but not needed right away easy Short and simple to code or review labels Aug 13, 2024
@zpotthoff
Copy link

Hi @dpanici, is this issue still open? I'm happy to work on it if it is.

@dpanici dpanici added P1 Lowest Priority, will get to eventually and removed low priority Nice to have, but not needed right away labels Nov 11, 2024
@dpanici
Copy link
Collaborator Author

dpanici commented Nov 11, 2024

@zpotthoff yes it is still open! feel free to open a PR and work on this issue, thanks!

@dpanici dpanici assigned dpanici and zpotthoff and unassigned dpanici Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zpotthoff zpotthoff

Labels
documentation Add documentation or better warnings etc. easy Short and simple to code or review P1 Lowest Priority, will get to eventually
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpanici @zpotthoff