Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types for StaticProps #1978

Open
mohitb35 opened this issue Feb 15, 2024 · 0 comments
Open

Missing types for StaticProps #1978

mohitb35 opened this issue Feb 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mohitb35
Copy link
Collaborator

mohitb35 commented Feb 15, 2024

This is a common issue across pages, and can probably be taken care of in a separate PR.

  1. The type defined for StaticProps currently excludes the results of serverSideTranslations, and should be updated to include the same.
  2. The same applies for pageProps
  3. Instead of defining the type for pageProps separately, it could be inferred from getServerSideProps, or be common with StaticProps.

#1765 (comment)

@mohitb35 mohitb35 added the bug Something isn't working label Feb 15, 2024
@mohitb35 mohitb35 mentioned this issue Feb 15, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant