Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portrait video area in player v4 VS others #137

Open
yarez0 opened this issue Sep 6, 2018 · 3 comments
Open

portrait video area in player v4 VS others #137

yarez0 opened this issue Sep 6, 2018 · 3 comments

Comments

@yarez0
Copy link

yarez0 commented Sep 6, 2018

Hi guys,

I'm actually using the player v4 because video in portrait mode can be displayed without schrolling the page to the bottom of the page, put it un full screen then play with the option MAX SIZE (set to full HD for me)

why the other player does not have this option or is there a way to fit the portrait video in the screen area ? does the option RESOLUTION_DESC does this ? I can't test it, the button is always set to NO (maybe a translate problem ? I'm in french version and I saw this https://github.com/xbgmsharp/piwigo-videojs/issues/125 but I don't understand the purpose)

Landscape video fit the page area, the problem is only for portrait.

Piwigo 2.9.4
Système d'exploitation: Linux
PHP: 7.2.9-1+020180901081133.4+stretch1.gbpdaac35
MySQL: 5.5.61 [2018-09-06 14:45:04]
Bibliothèque graphique: External ImageMagick 6.9.7-4
theme bootstrap_default
videojs 2.9.b

@yarez0
Copy link
Author

yarez0 commented Sep 6, 2018

sorry in lanscape the video is oversized, no horizontal scroll bar, back to browser player

@georg90
Copy link

georg90 commented Jun 13, 2019

I have the same issue using a combination of Bootstrap Darkroom theme (using the built in photoswipe) and videoJS.

Videos in landscape play just fine using the "browser" player. However, videos in portrait mode are off (see pictures below)

Okay (video thumb is centered, when clicked, video gets played in the same area:
image

Not okay (thumb is in the correct area, when clicked, player is off the screen and starts playing but is not visible):
image

@tkuther
Copy link

tkuther commented Jul 1, 2019

@georg90 PhotoSwipe in bootstrap darkroom bypasses the VideoJS library and uses native HTML5 with custom calculations, so this isn't related to piwigo-videojs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants