-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build system doesn't detect modified files #264
Comments
Project build - the main feature of the plugin - is broken and no one cares about it? That's strange. |
Try last release https://ci.appveyor.com/project/vosen/visualrust/build/145/artifacts . It use cargo to build a project |
@Vbif, MSBuild.exe crashes with System.NullReferenceException while trying to build default "Hello, world!" project. |
I fixed one MSBuild NullReferenceException crash which I suspect was @Vort 's issue in #286 . Unofficial test build @ https://ci.appveyor.com/project/MaulingMonkey/visualrust/build/1/artifacts , no idea if it's appropriately codesigned or not. Changes to the project are showing up in builds (e.g. @MihaMarkic 's original bug is fixed?) for me as of: |
@MaulingMonkey, I've tested that build with VS 2015 and Rust 1.19.0. |
I hope so, but so far nobody's reviewed my pull request. |
The maintainer of this project is @vosen, and he's also the only one who can release new versions. Unfortunately I do not have time right now to review myself, and also I don't know enough about vosen's plans for the future direction of some features of VisualRust, making it hard for me to review any non-trivial PRs. But anyway, thank you very much for your PR, @MaulingMonkey! 👍 |
I did notice @vosen shows some activity every month or two, so I'm hopeful my changes might at least get reviewed in the next cycle. And I'm assuming this is largely volunteer work or side projects, so it's completely understandable to be pressed for time, and to have higher priorities elsewhere 😉. Worst case scenario I can start more actively maintaining my own fork as a longer term thing - I just want to avoid it becoming another permanent fork if it can at all be helped. Thanks for the kind words, and your work which I'm building on, @Boddlnagg 👍 |
"Build Solution" won't detect modified files and won't compile anything if there is an earlier compilation available. "Rebuild Solution" will work.
Steps to reproduce:
Create a new project, compile it, change output from Hello World! to something else, do a Build Solution and run it.
Expected behavior:
New text should be visible.
Actual behavior:
"Hello world!" is displayed.
System
VS2015, rustc 1.14.0, VR 0.1.2
The text was updated successfully, but these errors were encountered: