-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BEWARE of the linked fork in the readme #169
Comments
Hi @CptFabulouso, on my project, I'm not targeting android 12 and I don't have this problem.
And we tested on several android 12 devices and we didn't have any problems. Could you please give me more information about your problem maybe I missed something? |
After using the forked version our app started to crash because of this
Not sure why we have compileSdkVersion set to 31 right now, could that be the reason? Besides this lib we are using |
@CptFabulouso ok so we have the same gradle and react-native version, and I'm using the ble-plx for Bluetooth. Can you please try to declare the permissions like this:
If this is not working then I will set the SDK to 30 and test to see how it works, it shouldn't be a problem because it was just an extra thing that I did. |
@manualexSP Hi, I finally got around to test this once again with clean RN project to eliminate issues in my setup. I created this repo to test this out https://github.com/CptFabulouso/nordic-dfu-fork-issue-repo There's readme how to simulate the crash, look for
and with that the app was working on Android 12 fine. After using the fork app crashes and it is required to specify and use |
If you do not target Android 12 and your app is running on Android 12, the suggest fork Salt-PepperEngineering/react-native-nordic-dfu will somehow remove BLUETOOTH_CONNECT and BLUETOOTH_SCAN permissions (which are granted automatically if you do not target Android 12), leading to your app crashing whenever using Bluetooth.
The text was updated successfully, but these errors were encountered: