Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken iOS build without cpp flags on react-native v0.68.1 #163

Open
uloco opened this issue May 4, 2022 · 2 comments
Open

broken iOS build without cpp flags on react-native v0.68.1 #163

uloco opened this issue May 4, 2022 · 2 comments

Comments

@uloco
Copy link

uloco commented May 4, 2022

Since react-native version 0.68.1 they moved to a Appdelegate.mm file which breaks the iOS build for react-native-nordic-dfu. The error is caused by using the @import iOSDFULibrary Syntax.

The error says that the @import syntax is only allowed when the -fcxx-modules and -fmodules flags are set.

When I enable these flags the whole react-native project stops building when reaching the first AppDelegate.h, because cplusplus dependencies are not linked correctly here and react-native cannot be built way more earlier in the build.

Do you have plans on changing the syntax or is there way to patch this @import into a classic #import <Filename> syntax to prevent the need to add those cpp flags?

See also here facebook/react-native#33692

@Rostyslow
Copy link

any updates?

@CptFabulouso
Copy link

Here's what I found #171 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants