Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add final few location images and interactions #337

Open
6 tasks
kvesik opened this issue Jun 20, 2024 · 0 comments
Open
6 tasks

Add final few location images and interactions #337

kvesik opened this issue Jun 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kvesik
Copy link
Collaborator

kvesik commented Jun 20, 2024

Location module images

When issue #85 was closed, there were a couple of placeholders/workarounds we were using that need to eventually be implemented properly. These are the outstanding items:

Mouth interior

For regions inside the mouth (tongue, upper teeth, lower teeth) highlighted by default in yellow, we are temporarily using the violet "Mouth" image as a placeholder. There are empty .txt files in the yellow subfolder of predefined_locations that flag their corresponding .svg files as placeholders.

  • The end goal is to have location drawings that show the interior of the mouth.
  • This means means we will likely also need a "Mouth" tab in addition to Front & Back.

Selected fingers

For regions involving selected fingers (selected fingers, selected fingers and thumb) highlighted by default in yellow, we are temporarily using the violet "Whole hand" image as a placeholder. There are empty .txt files in the yellow subfolder of predefined_locations that flag their corresponding .svg files as placeholders.

  • The end goal is to have location drawings that show the various possible combinations of selected finger(s) with and without thumb.
  • This means we will likely also need some logic to link whatever the "selected fingers" are (this is not yet implemented in any way) to EITHER:
    • (a) pre-made static images of all the various possible combinations of selected finger(s)/thumb, or
    • (b) images programmatically combined on-the-fly from the various individual finger/thumb images.

Side view

This one is a slightly different kind of issue. We do have a side view full-body drawing for use in the Location module, but as far as I can see there were never any versions of it created that show actual location regions highlighted on the body. So for now, I've removed the Side view tab from the Location module since it wasn't providing any useful information anyway. However, it would make sense to eventually:

  • have someone create drawings (from the original base) showing any relevant location regions viewed from the side, and
  • reintroduce the Side tab to the Location module.

See original mention of the first two topics here:
Originally posted by @kvesik in #85 (comment)

@kvesik kvesik added the enhancement New feature or request label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant