Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Arms and Legs Tab to Sign Type Specification View #389

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

partobm
Copy link

@partobm partobm commented Nov 1, 2024

Hello!

I implemented tabs for the Sign Type Specification View window to extend it for arms and legs. Please have a look at my implementation, and let me know if there are any issues/concerns. Thank you!

Parto

@partobm partobm linked an issue Nov 1, 2024 that may be closed by this pull request
@kchall
Copy link
Member

kchall commented Nov 1, 2024

Great, thanks, @partobm ! Visually it looks great, but at the moment, I'm running into an error saving anything (even hand specifications). If I select something and then click 'save,' I get the following error, regardless of which tab I'm on:

Traceback (most recent call last):
File "", line 1, in
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/idlelib/run.py", line 156, in main
ret = method(*args, **kwargs)
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/idlelib/run.py", line 559, in runcode
exec(code, self.locals)
File "/Users/KCH/Desktop/SLPAA/src/main/python/main.py", line 8, in
exit_code = appctxt.run()
File "/Users/KCH/Desktop/SLPAA/src/main/python/gui/app.py", line 23, in run
return self.app.exec_()
File "/Users/KCH/Desktop/SLPAA/src/main/python/gui/panel.py", line 907, in handle_signtypebutton_click
signtype_selector.exec_()
File "/Users/KCH/Desktop/SLPAA/src/main/python/gui/signtypespecification_view.py", line 1021, in handle_button_click
newsigntype = self.signtype_widget.getsigntype()
File "/Users/KCH/Desktop/SLPAA/src/main/python/gui/signtypespecification_view.py", line 805, in getsigntype
addedinfo = self.addedinfobutton.addedinfo
AttributeError: 'SigntypeSpecificationPanel' object has no attribute 'addedinfobutton'

partobm and others added 2 commits November 10, 2024 19:56
…aved_changes flag to True, just like if they'd been made from the sign level menu
@kvesik
Copy link
Collaborator

kvesik commented Nov 14, 2024

Hi @kchall and @partobm -- sorry I'm late to the party! I hadn't seen a notification when this PR was first created.

Thanks so much for your work on this, Parto. A couple of things I noticed as I tried out the functionality in branch 332:

  • @kchall maybe this is more directed at you-- do we want the arm & leg abbreviations to be formatted the same way as the hand ones (ie, for display in the signtype module in the sign summary window)?
  • Changes to sign type made from the sign summary panel weren't setting the unsaved_changes flag to True in the same way that signtype changes made from the sign level menu were. This is independent of your work-- it was a bug from before. I just pushed a change to branch 332 to fix this issue.
  • There is, however, a bug in the way that the specs lists are represented for the hand vs arm vs leg signtypes. Example: Load the sample corpus and work with the first sign, BEER. Open its signtype dialog, which is set to one hand / the hand moves. Switch to the Arms tab and select Unspecified, then save. Reopen signtype dialog and notice that hand has been set to unspecified, and Arm is back to empty. This is due to the fact that the underlying "Unspecified" signtype spec doesn't have any way of differentiating between being unspecified for hand vs arm vs leg.

@kchall
Copy link
Member

kchall commented Nov 16, 2024

@partobm, @kvesik

Thanks, both! Yes, now that I can save sign types, I see what Kaili means about the displays not matching. Ideally, yes, the summary of the Sign Type in the main window would be formatted the same, regardless of hand / arm / leg being chosen. So e.g. if analogous selections are made, the sign type summary should be analogous too:

image

Two other requests:

  1. Would it be possible to bold the name of any tab that has a selection made? This is our convention in other modules when something 'extra' has been added that isn't immediately visible, just as a way of flagging that there is information there. So e.g. if both the "hands" and "legs" tabs have selections, they would be bolded, unlike the "arms" tab:
image
  1. It would also be super helpful if when the sign type dialogue box is opened, it could default to displaying the first tab on which something is selected. So e.g. if only "arms" are selected, then opening the module shows us the "arms" tab by default, instead of the empty "hands" tab.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add arms / legs to "sign type" selection
3 participants