-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Arms and Legs Tab to Sign Type Specification View #389
base: main
Are you sure you want to change the base?
Conversation
Great, thanks, @partobm ! Visually it looks great, but at the moment, I'm running into an error saving anything (even hand specifications). If I select something and then click 'save,' I get the following error, regardless of which tab I'm on: Traceback (most recent call last): |
…aved_changes flag to True, just like if they'd been made from the sign level menu
Hi @kchall and @partobm -- sorry I'm late to the party! I hadn't seen a notification when this PR was first created. Thanks so much for your work on this, Parto. A couple of things I noticed as I tried out the functionality in branch 332:
|
Hello!
I implemented tabs for the Sign Type Specification View window to extend it for arms and legs. Please have a look at my implementation, and let me know if there are any issues/concerns. Thank you!
Parto