Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide "SetupWizard" via Bean instead of by Injection #1126

Open
madoar opened this issue Sep 12, 2019 · 2 comments
Open

Provide "SetupWizard" via Bean instead of by Injection #1126

madoar opened this issue Sep 12, 2019 · 2 comments

Comments

@madoar
Copy link
Collaborator

madoar commented Sep 12, 2019

Currently we provide a UiSetupWizardImplementation by calling the injected SetupWizard(...) method. This looks strange to me, because we normally provide functionality implemented on the Java side with Beans. What do you think, should we add a bean class on the Java side, that creates a new UiSetupWizardImplementation instance, instead of the injected method?

@plata
Copy link
Collaborator

plata commented Sep 16, 2019

Makes sense to me.

@plata
Copy link
Collaborator

plata commented Mar 15, 2021

@bubach is your problem related to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants